Bug 1455182

Summary:	ignore incorrect uuid validation in gd_validate_mgmt_hndsk_req
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	glusterd	Assignee:	bugs <bugs>
Status:	CLOSED EOL	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.10	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1454375	Environment:
Last Closed:	2018-06-20 18:30:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1454375
Bug Blocks:	1455177

Description Atin Mukherjee 2017-05-24 12:23:25 UTC

+++ This bug was initially created as a clone of Bug #1454375 +++

Description of problem:

In GlusterD's gd_validate_mgmt_hndsk_req () we ignore failure in fetching uuid from the dictionary to ensure backward compatibility, however the subsequent check still mandate to use peerid parsed from uuid. More details at http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-05-22 11:02:16 EDT ---

REVIEW: https://review.gluster.org/17358 (glusterd: ignore incorrect uuid validation if uuid_str is empty) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-05-23 14:34:40 EDT ---

REVIEW: https://review.gluster.org/17358 (glusterd: ignore incorrect uuid validation if uuid_str is empty) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-05-24 08:15:10 EDT ---

COMMIT: https://review.gluster.org/17358 committed in master by Atin Mukherjee (amukherj) 
------
commit b1fbc695a63801a3a2c62738fd6660388123724a
Author: Atin Mukherjee <amukherj>
Date:   Mon May 22 20:23:06 2017 +0530

    glusterd: ignore incorrect uuid validation if uuid_str is empty
    
    If uuid_str is not filled up in dictionary (when glusterd bit is old),
    we shouldn't be additional validation with peer uuid otherwise the
    handshake request will fail.
    
    Refer :
    http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
    Credits : pawan
    
    Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
    BUG: 1454375
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17358
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    Reviewed-by: Prashanth Pai <ppai>

Comment 1 Worker Ant 2017-05-24 12:24:15 UTC

REVIEW: https://review.gluster.org/17386 (glusterd: ignore incorrect uuid validation if uuid_str is empty) posted (#1) for review on release-3.10 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2017-05-30 13:35:42 UTC

COMMIT: https://review.gluster.org/17386 committed in release-3.10 by Raghavendra Talur (rtalur) 
------
commit 541e6a0079e50aa36e37270a91d86fccb2467ee4
Author: Atin Mukherjee <amukherj>
Date:   Mon May 22 20:23:06 2017 +0530

    glusterd: ignore incorrect uuid validation if uuid_str is empty
    
    If uuid_str is not filled up in dictionary (when glusterd bit is old),
    we shouldn't be additional validation with peer uuid otherwise the
    handshake request will fail.
    
    Refer :
    http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
    Credits : pawan
    
    >Reviewed-on: https://review.gluster.org/17358
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Amar Tumballi <amarts>
    >Reviewed-by: Prashanth Pai <ppai>
    >(cherry picked from commit b1fbc695a63801a3a2c62738fd6660388123724a)
    
    Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
    BUG: 1455182
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17386
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Raghavendra Talur <rtalur>

Comment 3 Shyamsundar 2018-06-20 18:30:34 UTC

This bug reported is against a version of Gluster that is no longer maintained
(or has been EOL'd). See https://www.gluster.org/release-schedule/ for the
versions currently maintained.

As a result this bug is being closed.

If the bug persists on a maintained version of gluster or against the mainline
gluster repository, request that it be reopened and the Version field be marked
appropriately.