Bug 1455283

Summary:	Cannot suspend server role in CFME Region menu
Product:	Red Hat CloudForms Management Engine	Reporter:	Matouš Mojžíš <mmojzis>
Component:	UI - OPS	Assignee:	Harpreet Kataria <hkataria>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Parthvi Vala <pvala>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.8.0	CC:	hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	Regression, TestOnly, ZStream
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	configuration:ui
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1460366 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:26:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1460366

Description Matouš Mojžíš 2017-05-24 16:15:59 UTC

Description of problem:


Version-Release number of selected component (if applicable):
5.8.0.16

How reproducible:
Always

Steps to Reproduce:
1. Go to Configuration -> Diagnostics -> CFME Region 
2. Select Roles by Servers and "Role: Web Services
3. Configuration in toolbar -> Suspend role

Actual results:
Button is disabled and alt is telling:" Only active Roles on active Servers can be suspended".
Role is active on active server.

Expected results:
Button should not be disabled.

Additional info:

Comment 2 Harpreet Kataria 2017-05-24 16:29:08 UTC

https://github.com/ManageIQ/manageiq-ui-classic/pull/1428

Comment 3 CFME Bot 2017-05-25 08:53:33 UTC

New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/2bd10eec7a5366ea3445241107461a8f850c12da

commit 2bd10eec7a5366ea3445241107461a8f850c12da
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed May 24 12:25:57 2017 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed May 24 12:26:56 2017 -0400

    Fixed condition in disabled? method
    
    Fixed a check in disabled? method introduced in commit 4b33666a0990231ecc7f3de899ccace90a6a4070 during refactoring of toolbar methods in https://github.com/ManageIQ/manageiq/pull/13052
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1455283

 app/helpers/application_helper/button/role_suspend.rb        |  4 ++--
 spec/helpers/application_helper/buttons/role_suspend_spec.rb | 11 +++++++++++
 2 files changed, 13 insertions(+), 2 deletions(-)

Comment 5 Matouš Mojžíš 2017-11-08 18:04:08 UTC

Verified in 5.9.0.5. Button is not disabled anymore.