Bug 1455452 (ovirt-dnf-2.0-support)

Summary:	[Tracker] Adapt to dnf-2.0
Product:	[oVirt] otopi	Reporter:	Yedidyah Bar David <didi>
Component:	Plugins.packagers	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED DEFERRED	QA Contact:	Lucie Leistnerova <lleistne>
Severity:	high	Docs Contact:
Priority:	medium
Version:	master	CC:	bugs, gzaidman, lleistne
Target Milestone:	---	Flags:	ylavi: ovirt-4.3+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-01 14:47:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1441164, 1455456, 1455482, 1542492, 1542529
Bug Blocks:

Description Yedidyah Bar David 2017-05-25 08:53:49 UTC

Description of problem:

dnf-2.0 [1], to be included in fedora 26, drops all non-official functions [2].

This bug is to track all current such uses in otopi.

[1] https://fedoraproject.org/wiki/Changes/DNF-2.0
[2] http://dnf.readthedocs.io/en/latest/dnf-1_vs_dnf-2.html#all-non-api-methods-and-attributes-are-private

Comment 1 Michal Skrivanek 2020-03-19 15:41:37 UTC

We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it.
If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly.

Comment 2 Yedidyah Bar David 2020-03-22 06:58:14 UTC

Closing current bug means we slightly raise the chance that dnf will break otopi unexpectedly. I can live with that, as long as this is clear.

I actually looked at it a few days ago, and the summary IIRC is:

We already simply use private dnf methods (can break anytime), except for one case (IIRC not tracked by current bug, even indirectly): We stopped checking signatures completely, waiting for dnf to officially expose means to do that. See bug 1339617 and bug 1344270. I think I'll simply push a patch to use the private method _sig_check_pkg and forget about it as well, until it breaks.

Comment 3 Michal Skrivanek 2020-04-01 14:47:42 UTC

Closing old bug. Please reopen if still relevant/you want to work on it.