Bug 1455513

Summary:	'rhncfg-client diff' does not print filenames of binary files
Product:	Red Hat Satellite 5	Reporter:	Ales Dujicek <adujicek>
Component:	Client	Assignee:	Tomáš Kašpárek <tkasparek>
Status:	CLOSED ERRATA	QA Contact:	Martin Korbel <mkorbel>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	580	CC:	mkorbel, mmraka, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rhncfg-5.10.87-11-sat	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-15 13:27:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1450111

Description Ales Dujicek 2017-05-25 11:57:58 UTC

Description of problem:

rhncfg-client diff does not print binary file names, so you have no clue what files differ

# rhncfg-client diff
Using server name host-8-177-44.host.centralci.eng.rdu2.redhat.com
Binary file content differs.
--- /tmp/conf-text	Wed May 24 09:32:30 2017
+++ /tmp/conf-text	Thu May 25 05:18:07 2017
@@ -1,3 +1,2 @@
-text
 file
 good


Version-Release number of selected component (if applicable):
rhncfg-5.10.87-10

How reproducible:
always

Steps to Reproduce:
1. create configure channel with binary file
2. subscribe this channel
3. rhncfg-client diff /file.binary
   rhncfg-namager diff /file.binary -c channel

Actual results:
Binary file content differs.

Expected results:
something like Binary file /tmp/binary content differs.

Additional info:
related bz1395881

Comment 1 Tomáš Kašpárek 2017-08-02 13:27:13 UTC

spacewalk-git(master): 5207ef77da4b69f86ac7ad772d4f1117d2e7fdc6
bfb726bc389864764b6e421a930a036757443169
d7f806a87c41455326cd60c92e585f086724bc58

Comment 2 Michael Mráka 2017-08-04 12:06:43 UTC

Backported to SATELLITE-5.8 as
commit 36106b25b2421526a2db2ddf59502d771b9d1d98
    1455513 - print different message if file does not exist
commit 44223a6838b14e377c4f69092478956b6dce8b38
    1455513 - print a name of file which does not exist during diff
commit e07b29e54e8f734b8a16e32f351aa484e2fb2165
    1455513 - tell user which file differs

Comment 4 Martin Korbel 2017-08-09 07:48:57 UTC

VERIFIED on rhncfg-5.10.87-11-sat

Reproducer via comment 0

> rhncfg-client diff /root/logo.png

(old version)
Using server name satellite.redhat.com
Binary file content differs.


(new version)
Using server name satellite.redhat.com
Binary file /root/logo.png differs.

Comment 6 errata-xmlrpc 2017-08-15 13:27:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2474