Bug 1455832

Summary:	No overwrite confirmation pops if keep name as default 'Screenshot'
Product:	Red Hat Enterprise Linux 7	Reporter:	Xiaodai Wang <xiaodwan>
Component:	virt-viewer	Assignee:	Virt Viewer Maint <virt-viewer-maint>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.4	CC:	dblechte, elima, jjongsma, juzhou, kuwei, mxie, mzhan, rbalakri, tzheng
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-viewer-5.0-8.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-04-10 08:50:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xiaodai Wang 2017-05-26 08:59:50 UTC

Description of problem:
No overwrite confirmation pops if keep name as default 'Screenshot'

Version-Release number of selected component (if applicable):
virt-viewer-5.0-4.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Open virt-viewer.
2. Click 'File->Screenshot', check the default name is "Screenshot".
3. Click 'Save' button, the picture is saved as 'Screenshot.png'.
4. Click 'File->Screenshot', then Click 'Save' button again.

Actual results:
The previous 'Screenshot.png' is overwritten silently. 

Expected results:
The previous 'Screenshot.png' should not be overwritten silently.

Additional info:
I suggest changing default name from 'Screenshot' to 'Screenshot.png' or appending date time after 'Screenshot' as RHEL system does.

Comment 2 Pavel Grunt 2017-05-26 09:13:04 UTC

sounds like reasonable request, too late for 7.4 -> moving

Comment 3 Jonathon Jongsma 2017-07-20 14:08:43 UTC

Relevant patches already pushed upstream:
a51ae4507d223a655f5c0a9054128becc5c3b689
f1783c3a3f403dcb2599b846dbbef6ff8369ae9f
761149ea71db5f51edce1d16860165bae2615917

Comment 5 Xiaodai Wang 2017-10-20 03:27:46 UTC

I verified the bug with virt-viewer-5.0-8.el7.x86_64.

1) the default filename is "Screenshot.png"
2) An error dialog pops up if no file extension was specified or wrong extension was specified.
3) An overwrite confirmation dialog pops up if same file has already existed.


so move the bug from ON_QA to VERIFIED.

Comment 8 errata-xmlrpc 2018-04-10 08:50:15 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0672