Bug 1455843

Summary:	atomioc-openshift-node systemd config file path should be same with installation
Product:	OpenShift Container Platform	Reporter:	Anping Li <anli>
Component:	Cluster Version Operator	Assignee:	Steve Milner <smilner>
Status:	CLOSED ERRATA	QA Contact:	Anping Li <anli>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	aos-bugs, jokerman, mmccomas, smunilla
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-10 05:25:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Anping Li 2017-05-26 09:55:08 UTC

Description of problem:
In v3.6, the rpm installation use the new path /etc/systemd/system/atomic-openshift-node.service But after upgrade, atomic-openshift-node is still using /usr/lib/systemd/system/atomic-openshift-node.service.

<  Loaded: loaded (/usr/lib/systemd/system/atomic-openshift-node.service; enabled; vendor preset: disabled)
---
>    Loaded: loaded (/etc/systemd/system/atomic-openshift-node.service; enabled; vendor preset: disabled)




Version-Release number of selected component (if applicable):
atomic-openshift-3.6.85-1.git.0.1393c16.el7.x86_64
openshift-ansible-3.6.85-1.git.0.109a54e.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. rpm install OCP 3.5
2. Upgrade to OCP 3.6
3. rpm Install OCP 3.6.
4. compare the atomic-openshift-node systemd configure file.



Actual results:
<    Loaded: loaded (/usr/lib/systemd/system/atomic-openshift-node.service; enabled; vendor preset: disabled)
---
>    Loaded: loaded (/etc/systemd/system/atomic-openshift-node.service; enabled; vendor preset: disabled)


Expected results:
Use same path with installation.

Additional info:

Comment 1 Scott Dodson 2017-05-31 00:50:33 UTC

Probably just needs a daemon reload? Likely related to the changes made as part of the system container work which moved all units into /etc/systemd/system deployed via ansible.

Comment 2 Steve Milner 2017-05-31 14:50:11 UTC

PR: https://github.com/openshift/openshift-ansible/pull/4322

Comment 3 Steve Milner 2017-06-02 12:42:49 UTC

Merged.

Comment 5 Anping Li 2017-06-05 17:03:53 UTC

@Steve, there isn't /etc/systemd/system/atomic-openshift-node.service on nodes. Maybe it need to be copied in the role /usr/share/ansible/openshift-ansible/roles/openshift_node_upgrade/tasks

Comment 6 Steve Milner 2017-06-05 18:47:50 UTC

I've created https://github.com/openshift/openshift-ansible/pull/4371 to copie the node unit file on upgrade.

Comment 7 Anping Li 2017-06-09 10:02:29 UTC

Verified and pass with atomic-openshift-utils-3.6.89.4-1.git.0.7c6d6a7.el7.noarch

[root@qe-anli-2 ~]# systemctl status atomic-openshift-node
● atomic-openshift-node.service - Atomic OpenShift Node
   Loaded: loaded (/etc/systemd/system/atomic-openshift-node.service; enabled; vendor preset: disabled)

Comment 9 errata-xmlrpc 2017-08-10 05:25:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716