Bug 1455899 (qt5-qtremoteobjects)

Summary: Review Request: qt5-qtremoteobjects - Qt5 - Qt Remote Objects
Product: [Fedora] Fedora Reporter: Helio Chissini de Castro <helio>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, rdieter, zebob.m
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: zebob.m: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-10 05:03:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 928937    

Description Helio Chissini de Castro 2017-05-26 12:07:59 UTC
Spec URL: https://heliocastro.fedorapeople.org/qt5-qtremoteobjects.spec
SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtremoteobjects-5.9.0-0.beta.3.fc27.src.rpm
Description: Qt Remote Objects (QtRO) is an inter-process communication (IPC) module developed for Qt.
Fedora Account System Username: heliocastro

Comment 1 Robert-André Mauchin 🐧 2017-09-13 14:46:10 UTC
Hello,


 - Same as before, please split your description lines to be under 80 characters per line.

 - You've got a file listed twice:

  Note: warning: File listed twice: /usr/lib64/cmake/Qt5RemoteObjects
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

 - Please bump to version rc2.


All of this is trivial so the package is accepted but please fix them before import.




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib64/cmake/Qt5RemoteObjects
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "GPL (v3)", "LGPL (v2.1 or v3)", "GPL (v3)
     LGPL (v3)", "Unknown or generated". 195 files have unknown license.
     Detailed output of licensecheck in
     /home/bob/packaging/review/qt5-qtremoteobjects/review-
     qt5-qtremoteobjects/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/qt5/bin
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib64/qt5/examples(qt5
     -qtxmlpatterns-examples, qt5-qt3d-examples, qt5-qtwebchannel-examples,
     qt5-qtserialbus-examples, qt5-qtwebsockets-examples, qt5-qtscript-
     examples, qt5-qtenginio-examples, qt5-qtconnectivity-examples, qt5
     -qtdeclarative-examples, qt5-qtsensors-examples, qt5-qttools-examples,
     qt5-qtmultimedia-examples, qt5-qtdatavis3d-examples, qt5-qtserialport-
     examples, qt5-qtwebengine-examples, qt5-qtwebview-examples, qt5
     -qtcharts-examples, qt5-qtquickcontrols-examples, qt5-qtgamepad-
     examples, qt5-qtlocation-examples, qt5-qtvirtualkeyboard-examples, qt5
     -qtscxml-examples, qt5-qtsvg-examples, qt5-qtbase-examples),
     /usr/lib64/qt5/mkspecs/features(qt5-qtbase-devel),
     /usr/lib64/qt5/mkspecs/modules(qt5-qtbase-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in qt5
     -qtremoteobjects-debuginfo
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: qt5-qtremoteobjects-5.9.0-0.rc.2.fc28.x86_64.rpm
          qt5-qtremoteobjects-devel-5.9.0-0.rc.2.fc28.x86_64.rpm
          qt5-qtremoteobjects-examples-5.9.0-0.rc.2.fc28.x86_64.rpm
          qt5-qtremoteobjects-debuginfo-5.9.0-0.rc.2.fc28.x86_64.rpm
          qt5-qtremoteobjects-5.9.0-0.rc.2.fc28.src.rpm
qt5-qtremoteobjects.x86_64: E: description-line-too-long C Qt Remote Objects (QtRO) is an inter-process communication (IPC) module developed for Qt.
qt5-qtremoteobjects.x86_64: W: no-documentation
qt5-qtremoteobjects-devel.x86_64: W: only-non-binary-in-usr-lib
qt5-qtremoteobjects-devel.x86_64: W: no-documentation
qt5-qtremoteobjects-examples.x86_64: W: no-documentation
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/cppclient/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/modelviewclient/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/modelviewserver/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/server/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/server/timemodel.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/server/timemodel.h
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectclient/client.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectclient/client.h
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectclient/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectdynamicclient/dynamicclient.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectdynamicclient/dynamicclient.h
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectdynamicclient/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectserver/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectserver/simpleswitch.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/directconnectserver/simpleswitch.h
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/registryconnectedclient/dynamicclient.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/registryconnectedclient/dynamicclient.h
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/registryconnectedclient/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/registryconnectedserver/main.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/registryconnectedserver/simpleswitch.cpp
qt5-qtremoteobjects-examples.x86_64: W: devel-file-in-non-devel-package /usr/lib64/qt5/examples/remoteobjects/simpleswitch/registryconnectedserver/simpleswitch.h
qt5-qtremoteobjects.src: E: description-line-too-long C Qt Remote Objects (QtRO) is an inter-process communication (IPC) module developed for Qt.
5 packages and 0 specfiles checked; 2 errors, 25 warnings.

Comment 2 Rex Dieter 2017-11-06 20:06:42 UTC
repo/branch requests submitted

Comment 3 Gwyn Ciesla 2017-11-06 22:19:06 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qt5-qtremoteobjects

Comment 4 Rex Dieter 2017-11-20 19:07:00 UTC
imported

Comment 5 Fedora Update System 2017-11-22 06:32:56 UTC
qt5-qtremoteobjects-5.9.2-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b417582373

Comment 6 Fedora Update System 2017-12-10 05:03:33 UTC
qt5-qtremoteobjects-5.9.2-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.