Bug 1456211
| Summary: | missing private headets in cmake config | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Gmeiner <christian.gmeiner> | ||||
| Component: | qt5-qtdeclarative | Assignee: | Than Ngo <than> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 25 | CC: | christian.gmeiner, jgrulich, jreznik, lupinix.fedora, rdieter, than | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | qt5-qtdeclarative-5.7.1-8.fc26 qt5-qtdeclarative-5.7.1-8.fc25 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-06-20 01:49:37 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Christian Gmeiner
2017-05-27 21:44:33 UTC
pretty sure qtwebkit doesn't use cmake (but qmake) actually, the output you posted does indeed look like cmake. Have you confirmed adjusting Qt5QuickConfig.cmake helps? Also note this section of Qt5QuickConfig.cmake:
# Only check existence of private includes if the Private component is
# specified.
list(FIND Qt5Quick_FIND_COMPONENTS Private _check_private)
if (NOT _check_private STREQUAL -1)
foreach(_dir ${Qt5Quick_PRIVATE_INCLUDE_DIRS})
_qt5_Quick_check_file_exists(${_dir})
endforeach()
endif()
means qtwebkit needs to explicitly request the private headers, does it?
I'm also seeing this with qmake, but from logs I see that cmake is used in background anyway. I also get that issue on Rawhide with Qt 5.9.0 while Arch Linux already provides a new qt5-webkit → They build it successfully. Not I checked their Qt5QuickConfig.cmake and there is a difference in *exactly* that point (see attachment). Created attachment 1288154 [details]
Diff between Fedora and Arch Qt5QuickConfig.cmake
diff -Naur Qt5QuickConfig.cmake.fedora Qt5QuickConfig.cmake.arch
Looks like we've stumbled upon upstream bug, https://bugreports.qt.io/browse/QTBUG-37417 Exactly, when I do the build of qt5-qtdeclarative in source tree, the resulting Qt5QuickConfig.cmake looks fine. I've built a copr [1] to test a change [2] Arch makes to fix this issue, so added to %prep in spec of qt5-qtbase: # Fix missing private includes https://bugreports.qt.io/browse/QTBUG-37417 sed -e '/CMAKE_NO_PRIVATE_INCLUDES\ \=\ true/d' -i mkspecs/features/create_cmake.prf Result: qt5-qtdeclarative rebuilt against this new qt5-qtbase build has proper definitions in Qt5QuickConfig.cmake. I think we should adapt the change to qt5-qtbase. [1] https://copr.fedorainfracloud.org/coprs/lupinix/qt59-test/ [2] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/qt5-base#n50 Oh, I just committed this: http://pkgs.fedoraproject.org/cgit/rpms/qt5-qtdeclarative.git/commit/?id=0153371fc6a5972d7b2f4eebdeb4f40e6c65b8cf to drop shadow builds, which reportedly fixes the issue too. I suppose we could adapt the CMAKE_NO_PRIVATE_INCLUDES change too, but no one knows if that has any side-effects (apparently not, other distros use that hack as well). OK, all other core qt5 modules no longer use shadow-builds, and added now to qt5-qtbase: %changelog * Fri Jun 16 2017 Rex Dieter <rdieter> - 5.9.0-3 - create_cmake.prf: adjust CMAKE_NO_PRIVATE_INCLUDES (#1456211,QTBUG-37417) that should theoretically avoid the issue for good qt5-qtdeclarative-5.7.1-8.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a01da57ff qt5-qtdeclarative-5.7.1-8.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1937fe117 qt5-qtdeclarative-5.7.1-8.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c1937fe117 qt5-qtdeclarative-5.7.1-8.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a01da57ff qt5-qtdeclarative-5.6.2-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-9016c421fd qt5-qtdeclarative-5.7.1-8.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. qt5-qtdeclarative-5.6.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-9016c421fd qt5-qtdeclarative-5.7.1-8.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. qt5-qtdeclarative-5.6.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |