Bug 1456268

Created attachment 1283027 [details]
engine & vdsm logs

Description of problem:
Via rest API it is possible to remove a storage domain using a host in maintenance .
This cause for the SPM not to umount the mount to the storage domain & if we recreate the same SD the SPM will not remount & mount options will be lost . 


Version-Release number of selected component (if applicable):
Engine:
4.1.2.2

VDSM:
4.19.15-1

How reproducible:
100%


Steps to Reproduce:

Setup:
2 hosts:
host_mixed_1 in maintenance .
host_mixed_2 is active & SPM .

1.Create storage domain via API on SPM host:

Method :
POST

URL:
https://storage-ge-01.scl.lab.tlv.redhat.com/ovirt-engine/api/storagedomains

Body :

<storage_domain>
<name>t1</name>
    <storage>
        <address>gluster-server01.qa.lab.tlv.redhat.com</address>
        <path>/storage_local_ge4_replica_3</path>
        <type>glusterfs</type>
        <vfs_type>glusterfs</vfs_type>
    </storage>
    <storage_format>v4</storage_format>
    <type>data</type>
    <host>
        <name>host_mixed_2</name>
    </host>
</storage_domain>


2. See that mount is added to SPM :
gluster-server01.qa.lab.tlv.redhat.com:/storage_local_ge4_replica_3 on /rhev/data-center/mnt/glusterSD/gluster-server01.qa.lab.tlv.redhat.com:_storage__local__ge4__replica__3 type fuse.glusterfs (rw,relatime,user_id=0,group_id=0,default_permissions,allow_other,max_read=131072)


3. remove + format storage doamin :

DELETE method from host in maintenance (host = host_mixed_1) :
https://storage-ge-04.scl.lab.tlv.redhat.com/ovirt-engine/api/storagedomains/9f87c7bf-3695-4e02-bf6d-8c7d75180bf7;host=host_mixed_1;format=True

Actual results:
Storage is removed but the mount is still there! 

In SPM vdsm log NO umount is seen , but in maintanacne host vdsm log umount is seen :
2017-05-28 17:15:25,993+0300 INFO  (jsonrpc/7) [storage.Mount] unmounting /rhev/data-center/mnt/glusterSD/gluster-server01.qa.lab.tlv.redhat.com:_storage__local__ge4__replica__3 (mount:195)


• This causes issues as if you recreate the storage with the same path but with different mount options, this will not be implemented.

Expected results:
Either it should NOT be allowed to delete storage domain from the host in maintenance/Non-active state.

OR

If prior is allowed make sure SPM active host should be updated as well & umount to SD should occur on SPM.

Additional info:

timeline :
May 28, 2017 5:13:01 PM
Storage Domain t1 was added by admin@internal-authz

May 28, 2017 5:15:27 PM
Storage Domain t1 was removed by admin@internal-authz

mount | grep replica
gluster-server01.qa.lab.tlv.redhat.com:/storage_local_ge4_replica_3 on /rhev/data-center/mnt/glusterSD/gluster-server01.qa.lab.tlv.redhat.com:_storage__local__ge4__replica__3 type fuse.glusterfs (rw,relatime,user_id=0,group_id=0,default_permissions,allow_other,max_read=131072)