Bug 1456734

Summary: Missing "data-id" attribute in Bootstrap select elements
Product: Red Hat CloudForms Management Engine Reporter: Dmitry Misharov <dmisharo>
Component: UI - OPSAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.9.0   
Hardware: All   
OS: All   
Whiteboard: ui:ansible
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1460802 (view as bug list) Environment:
Last Closed: 2018-03-06 15:29:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1460802    

Description Dmitry Misharov 2017-05-30 09:22:29 UTC 
Description of problem:
Bootstrap selects in Ansible/Credentials don't have any id. This makes it very difficult to write automation tests. In the same time in other parts of the UI Bootsrtap selects have "data-id" attribute.

Version-Release number of selected component (if applicable):
5.8.0.17.20170525183055_6317a22

How reproducible:
Always

Steps to Reproduce:
1. Enable Embedded Ansible Role.
2. Navigate to Automation/Ansible/Credentials
3. Open the creation dialog of a credential.

Actual results:
"Credential type" and "Privilege Escalation" bootstrap selects don't have "data-id" attribute.

Expected results:
"button" html tag should contain "data-id" attribute.

Additional info:
How the element looks now:
<button class="btn dropdown-toggle btn-default" type="button" data-toggle="dropdown" title="&lt;Choose&gt;" aria-expanded="false">
Comment 2 Milan Zázrivec 2017-06-05 14:23:30 UTC 
https://github.com/ManageIQ/manageiq-ui-classic/pull/1487
Comment 3 CFME Bot 2017-06-06 11:28:26 UTC 
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/5fc0bfa53b9327726d350fecbb285515cc15388a

commit 5fc0bfa53b9327726d350fecbb285515cc15388a
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Jun 5 16:22:00 2017 +0200
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Jun 5 16:22:00 2017 +0200

    Add IDs to ansible credential form selects
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1456734

 app/assets/javascripts/components/ansible-credential-options.js | 2 +-
 app/views/ansible_credential/_credential_form.html.haml         | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Comment 5 Dmitry Misharov 2017-10-18 07:22:10 UTC 
Verified in 5.9.0.2.20171010190026_0413a06. Bootstrap select elements have "data-id" and "id" attributes.