Bug 1456801

Summary: Incorrect importing of thin provision disks from KVM
Product: [oVirt] ovirt-engine Reporter: Alan Griffiths <alan>
Component: GeneralAssignee: Tomáš Golembiovský <tgolembi>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0CC: ahadas, alan, bugs, michal.skrivanek, tgolembi, tjelinek
Target Milestone: ovirt-4.3.0Flags: rule-engine: ovirt-4.3+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-14 14:41:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1332019    
Bug Blocks:    

Description Alan Griffiths 2017-05-30 12:04:25 UTC
When importing a VM from KVM with thin provision disk the resulting disk in oVirt will effectively be pre-allocated, despite the thin option being selected during the import process.

I believe this has a dependency on https://bugzilla.redhat.com/show_bug.cgi?id=1332019

Comment 1 Michal Skrivanek 2017-08-22 07:45:46 UTC
can you please check that it's still the case, do we need any more work other than using el7.4?

Comment 2 Tomáš Golembiovský 2017-08-29 20:13:00 UTC
(In reply to Alan Griffiths from comment #0)
> I believe this has a dependency on
> https://bugzilla.redhat.com/show_bug.cgi?id=1332019

I'm not entirely sure these two bugs are related. Can you confirm that your
problem is only the situation where the source KVM stores the images as raw (as
opposed to qcow2)?

If yes, then the problem is that we cannot efficiently transfer sparse files
between source and destination libvirt. This feature is tracked by bug 1282859.

Comment 3 Tomáš Golembiovský 2017-08-29 20:25:35 UTC
(In reply to Michal Skrivanek from comment #1)
> can you please check that it's still the case, do we need any more work
> other than using el7.4?

To answer this question: yes we will need to update kvm2ovirt to make use of the new libvirt feature.

Comment 4 Alan Griffiths 2017-08-30 08:07:32 UTC
My scenario was this: -

I had a number of VMs which had been provisioned with pre-allocated raw disks. I converted the disks to thin prov qcow2 using virt-sparsify, verified they still booted correctly, then imported into oVirt.

At the time it never occurred to me to check that they had actually been imported as thin-prov. It was only some time later when reviewing storage usage that I realised they were all pre-allocated.

Comment 5 Tomáš Golembiovský 2017-08-30 14:35:38 UTC
If the source was qcow2 file than it's not related to the bug I mentioned in comment 2. Without further info I guess I'll close it as it works for me.

What type of storage domain are you using in oVirt?

Comment 6 Alan Griffiths 2017-08-30 15:04:42 UTC
Block - Fibre channel.

Comment 7 Tomas Jelinek 2017-09-27 12:40:19 UTC
this will not make 4.2, postponing

Comment 8 Michal Skrivanek 2018-09-14 14:41:43 UTC
(In reply to Tomas Jelinek from comment #7)
> this will not make 4.2, postponing

oops, it just did. Fixed by bug 1628477 in 4.2.7