Bug 1456911

Summary:	Fix checking for valid VLan ID in NetworkManager connection
Product:	Red Hat Enterprise Linux 7	Reporter:	Thomas Haller <thaller>
Component:	NetworkManager	Assignee:	Thomas Haller <thaller>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.4	CC:	atragler, bgalvani, fgiudici, lrintel, rkhan, sukulkar, thaller, vbenes
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-1.8.0-5.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 09:28:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Thomas Haller 2017-05-30 16:24:49 UTC

VLAN ID 4095 is not a valid ID.
A user configuring it, will not succeed.

That was aimed to be fixed by https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=8715d61437060cacc68c156b1c8ed7bbce4b0a78 . This change, caused NM to reject VLAN ID 4095, but also failed to load existing connections on disk -- but that is no problem, because such connections were never functional!!


However, the fix was wrong, so it doesn't actually reject the 4095.
This got now fixed by https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=159cd4836fb32f3a6ecefa6fc4dcc114892ce32a


The fix is important, because otherwise a user can configure ID 4095 which triggers an assertion in NetworkManager.

Comment 2 Thomas Haller 2017-05-31 09:40:43 UTC

Reproducer:


just create a connection with VLAN ID 4095


$ nmcli connection add type vlan con-name t-vlan autoconnect no id 4095 dev enp0s25



correct result:
Error: Failed to add 't-vlan' connection: vlan.id: the vlan id must be in range 0-4094 but is 4095

Comment 4 errata-xmlrpc 2017-08-01 09:28:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2299