Bug 1457055

Summary:	lorax tracebacks when trying to make arm image
Product:	[Fedora] Fedora	Reporter:	Kevin Fenzi <kevin>
Component:	lorax	Assignee:	Brian Lane <bcl>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	anaconda-maint-list, bcl, dustymabe
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	lorax-27.1-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-31 16:35:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kevin Fenzi 2017-05-31 03:27:32 UTC

https://koji.fedoraproject.org/koji/taskinfo?taskID=19786730

DEBUG util.py:439:  populating output tree and building boot images
DEBUG util.py:439:  2017-05-30 23:03:46,016: Problem rendering arm.tmpl ({'kernels': [{'path': 'boot/vmlinuz-4.12.0-0.rc2.git3.1.fc27.armv7hl+lpae', 'version': '4.12.0-0.rc2.git3.1.fc27.armv7hl+lpae', 'arch': 'armv7hl', 'flavor': 'lpae', 'initrd': {'path': 'boot/initramfs-4.12.0-0.rc2.git3.1.fc27.armv7hl+lpae.img'}}, {'path': 'boot/vmlinuz-4.12.0-0.rc2.git3.1.fc27.armv7hl', 'version': '4.12.0-0.rc2.git3.1.fc27.armv7hl', 'arch': 'armv7hl', 'flavor': None, 'initrd': {'path': 'boot/initramfs-4.12.0-0.rc2.git3.1.fc27.armv7hl.img'}}], 'arch': {'buildarch': 'armv7hnl', 'basearch': 'armhfp', 'libdir': 'lib', 'bcj': 'arm'}, 'product': {'name': 'Fedora', 'version': 'Rawhide', 'release': 'Rawhide', 'variant': 'Workstation', 'bugurl': 'your distribution provided bug reporting tool', 'isfinal': False}, 'runtime_img': 'images/install.img', 'runtime_base': 'install.img', 'inroot': '/var/tmp/lorax.vwy6muax/installroot', 'outroot': '/mnt/koji/compose/rawhide/Fedora-Rawhide-20170530.n.2/work/armhfp/buildinstall/Workstation', 'basearch': 'armhfp', 'libdir': 'lib', 'isolabel': 'Fedora-WS-dvd-armhfp-rawh', 'udev': <function udev_escape at 0xb4593468>, 'domacboot': False, 'doupgrade': False, 'workdir': '/var/tmp/lorax.vwy6muax', 'lower': <function string_lower at 0xb45934b0>, 'exists': <function LoraxTemplateRunner.__init__.<locals>.<lambda> at 0xb39f2300>, 'glob': <function LoraxTemplateRunner.__init__.<locals>.<lambda> at 0xb39f2b70>}):
DEBUG util.py:439:  Problem rendering arm.tmpl ({'kernels': [{'path': 'boot/vmlinuz-4.12.0-0.rc2.git3.1.fc27.armv7hl+lpae', 'version': '4.12.0-0.rc2.git3.1.fc27.armv7hl+lpae', 'arch': 'armv7hl', 'flavor': 'lpae', 'initrd': {'path': 'boot/initramfs-4.12.0-0.rc2.git3.1.fc27.armv7hl+lpae.img'}}, {'path': 'boot/vmlinuz-4.12.0-0.rc2.git3.1.fc27.armv7hl', 'version': '4.12.0-0.rc2.git3.1.fc27.armv7hl', 'arch': 'armv7hl', 'flavor': None, 'initrd': {'path': 'boot/initramfs-4.12.0-0.rc2.git3.1.fc27.armv7hl.img'}}], 'arch': {'buildarch': 'armv7hnl', 'basearch': 'armhfp', 'libdir': 'lib', 'bcj': 'arm'}, 'product': {'name': 'Fedora', 'version': 'Rawhide', 'release': 'Rawhide', 'variant': 'Workstation', 'bugurl': 'your distribution provided bug reporting tool', 'isfinal': False}, 'runtime_img': 'images/install.img', 'runtime_base': 'install.img', 'inroot': '/var/tmp/lorax.vwy6muax/installroot', 'outroot': '/mnt/koji/compose/rawhide/Fedora-Rawhide-20170530.n.2/work/armhfp/buildinstall/Workstation', 'basearch': 'armhfp', 'libdir': 'lib', 'isolabel': 'Fedora-WS-dvd-armhfp-rawh', 'udev': <function udev_escape at 0xb4593468>, 'domacboot': False, 'doupgrade': False, 'workdir': '/var/tmp/lorax.vwy6muax', 'lower': <function string_lower at 0xb45934b0>, 'exists': <function LoraxTemplateRunner.__init__.<locals>.<lambda> at 0xb39f2300>, 'glob': <function LoraxTemplateRunner.__init__.<locals>.<lambda> at 0xb39f2b70>}):
DEBUG util.py:439:  2017-05-30 23:03:46,055: 
DEBUG util.py:439:  Traceback (most recent call last):
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/pylorax/ltmpl.py", line 56, in parse
DEBUG util.py:439:      textbuf = template.render(**variables)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/template.py", line 462, in render
DEBUG util.py:439:      return runtime._render(self, self.callable_, args, data)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 838, in _render
DEBUG util.py:439:      **_kwargs_for_callable(callable_, data))
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 873, in _render_context
DEBUG util.py:439:      _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 899, in _exec_template
DEBUG util.py:439:      callable_(context, *args, **kwargs)
DEBUG util.py:439:    File "/usr/share/lorax/templates.d/99-generic/arm.tmpl", line 60, in render_body
DEBUG util.py:439:      install ${f} ${f|basename}
DEBUG util.py:439:  TypeError: 'Undefined' object is not callable
DEBUG util.py:439:  Traceback (most recent call last):
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/pylorax/ltmpl.py", line 56, in parse
DEBUG util.py:439:      textbuf = template.render(**variables)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/template.py", line 462, in render
DEBUG util.py:439:      return runtime._render(self, self.callable_, args, data)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 838, in _render
DEBUG util.py:439:      **_kwargs_for_callable(callable_, data))
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 873, in _render_context
DEBUG util.py:439:      _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 899, in _exec_template
DEBUG util.py:439:      callable_(context, *args, **kwargs)
DEBUG util.py:439:    File "/usr/share/lorax/templates.d/99-generic/arm.tmpl", line 60, in render_body
DEBUG util.py:439:      install ${f} ${f|basename}
DEBUG util.py:439:  TypeError: 'Undefined' object is not callable
DEBUG util.py:439:  Traceback (most recent call last):
DEBUG util.py:439:    File "/usr/sbin/lorax", line 277, in <module>
DEBUG util.py:439:      main()
DEBUG util.py:439:    File "/usr/sbin/lorax", line 133, in main
DEBUG util.py:439:      remove_temp=True, verify=opts.verify)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/pylorax/__init__.py", line 357, in run
DEBUG util.py:439:      treebuilder.build()
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/pylorax/treebuilder.py", line 311, in build
DEBUG util.py:439:      self._runner.run(templatefile, kernels=self.kernels)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/pylorax/ltmpl.py", line 219, in run
DEBUG util.py:439:      commands = t.parse(templatefile, variables)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/pylorax/ltmpl.py", line 56, in parse
DEBUG util.py:439:      textbuf = template.render(**variables)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/template.py", line 462, in render
DEBUG util.py:439:      return runtime._render(self, self.callable_, args, data)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 838, in _render
DEBUG util.py:439:      **_kwargs_for_callable(callable_, data))
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 873, in _render_context
DEBUG util.py:439:      _exec_template(inherit, lclcontext, args=args, kwargs=kwargs)
DEBUG util.py:439:    File "/usr/lib/python3.6/site-packages/mako/runtime.py", line 899, in _exec_template
DEBUG util.py:439:      callable_(context, *args, **kwargs)
DEBUG util.py:439:    File "arm_tmpl", line 139, in render_body
DEBUG util.py:439:  TypeError: 'Undefined' object is not callable
DEBUG util.py:577:  Child return code was: 1

Comment 1 Dusty Mabe 2017-05-31 03:33:11 UTC

looks like it doesn't like this line [1] from this commit [2].

[1] https://github.com/rhinstaller/lorax/blob/9fe59eed0b329c0d870d1dfd532183bbdf7755df/share/templates.d/99-generic/arm.tmpl#L60
[2] https://github.com/rhinstaller/lorax/commit/9fe59eed0b329c0d870d1dfd532183bbdf7755df

Comment 2 Brian Lane 2017-05-31 16:35:40 UTC

Missed adding the basename import to the arm.tmpl

Fixed by https://github.com/rhinstaller/lorax/commit/f3d262c8f7ed5dccb21d9ea9d2ec4a6559a95382