Bug 1457524

Summary: Problem parsing formatted cipher list
Product: Red Hat Enterprise Linux 7 Reporter: Matthew Harmsen <mharmsen>
Component: tomcatjssAssignee: Endi Sukma Dewata <edewata>
Status: CLOSED ERRATA QA Contact: Asha Akkiangady <aakkiang>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4CC: edewata, gkapoor
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tomcatjss-7.2.1-4.el7 Doc Type: Bug Fix
Doc Text:
Previously the cipher list in server.xml had to be specified in a single long line which made it difficult to manage, for example: <Connector sslRangeCiphers="TLS_DHE_RSA_WITH_AES_128_CBC_SHA,TLS_DHE_RSA_WITH_AES_256_CBC_SHA,TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,TLS_DHE_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_128_CBC_SHA256,TLS_RSA_WITH_AES_256_CBC_SHA256" /> To improve usability the code has been changed to allow the cipher list to be specified in multiple lines, for example: <Connector sslRangeCiphers="TLS_DHE_RSA_WITH_AES_128_CBC_SHA, TLS_DHE_RSA_WITH_AES_256_CBC_SHA, TLS_DHE_RSA_WITH_AES_128_CBC_SHA256, TLS_DHE_RSA_WITH_AES_256_CBC_SHA256, TLS_DHE_RSA_WITH_AES_128_GCM_SHA256, TLS_RSA_WITH_AES_128_CBC_SHA256, TLS_RSA_WITH_AES_256_CBC_SHA256" />
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 21:09:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matthew Harmsen 2017-05-31 20:59:48 UTC
In some cases (e.g. in FIPS mode) the admin will need to modify the SSL cipher list in server.xml. Currently the cipher list needs to be specified as a single (and often times long) line without line breaks which makes it difficult to manage and error prone. For example:

<Connector
    sslRangeCiphers="TLS_DHE_RSA_WITH_AES_128_CBC_SHA,TLS_DHE_RSA_WITH_AES_256_CBC_SHA,TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,TLS_DHE_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_128_CBC_SHA256,TLS_RSA_WITH_AES_256_CBC_SHA256"
    />

To improve usability the cipher list should support the following format:

<Connector
   sslRangeCiphers="TLS_DHE_RSA_WITH_AES_128_CBC_SHA,
       TLS_DHE_RSA_WITH_AES_256_CBC_SHA,
       TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,
       TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,
       TLS_DHE_RSA_WITH_AES_128_GCM_SHA256,
       TLS_RSA_WITH_AES_128_CBC_SHA256,
       TLS_RSA_WITH_AES_256_CBC_SHA256"
    />

However, currently this format is not supported by TomcatJSS, causing the following error:

Error: SSL cipher "                TLS_DHE_RSA_WITH_AES_256_CBC_SHA" not recognized by tomcatjss
Error: SSL cipher "                TLS_DHE_RSA_WITH_AES_128_CBC_SHA256" not recognized by tomcatjss
Error: SSL cipher "                TLS_DHE_RSA_WITH_AES_256_CBC_SHA256" not recognized by tomcatjss
Error: SSL cipher "                TLS_DHE_RSA_WITH_AES_128_GCM_SHA256" not recognized by tomcatjss
Error: SSL cipher "                TLS_RSA_WITH_AES_128_CBC_SHA256" not recognized by tomcatjss
Error: SSL cipher "                TLS_RSA_WITH_AES_256_CBC_SHA256" not recognized by tomcatjss

The cipher list parser needs to be modified to support spaces and line breaks.

Comment 2 Endi Sukma Dewata 2017-05-31 23:23:38 UTC
Fixed in master:

* https://github.com/dogtagpki/tomcatjss/commit/c14c8ec6b077721eddeddb125b9a4b0141e5e4aa

Comment 4 Geetika Kapoor 2017-06-20 10:18:06 UTC
Test build:
===========
rpm -qa tomcatjss
tomcatjss-7.2.1-6.el7.noarch

Actual:
=========
Server.xml



           sslRangeCiphers="-TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA,-TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA,-TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA,-TLS_ECDH_RSA_WITH_AES_128_CBC_SHA,-TLS_ECDH_RSA_WITH_AES_256_CBC_SHA,-TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA,-TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,-TLS_ECDHE_ECDSA_WITH_3DES_EDE_CBC_SHA,-TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,-TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,-TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,-TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,-TLS_DHE_DSS_WITH_3DES_EDE_CBC_SHA,-TLS_DHE_DSS_WITH_AES_128_CBC_SHA,-TLS_DHE_DSS_WITH_AES_256_CBC_SHA,-TLS_DHE_RSA_WITH_3DES_EDE_CBC_SHA,-TLS_DHE_RSA_WITH_AES_128_CBC_SHA,-TLS_DHE_RSA_WITH_AES_256_CBC_SHA,-TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,-TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,-TLS_DHE_RSA_WITH_AES_128_GCM_SHA256,-TLS_DHE_DSS_WITH_AES_128_GCM_SHA256,-TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,-TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,-TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,-TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,-TLS_RSA_WITH_AES_128_CBC_SHA256,-TLS_RSA_WITH_AES_256_CBC_SHA256,-TLS_RSA_WITH_AES_128_GCM_SHA256,+TLS_RSA_WITH_3DES_EDE_CBC_SHA,+TLS_RSA_WITH_AES_128_CBC_SHA,+TLS_RSA_WITH_AES_256_CBC_SHA"


Expected:

Doesn't match the expected.

<Connector
   sslRangeCiphers="TLS_DHE_RSA_WITH_AES_128_CBC_SHA,
       TLS_DHE_RSA_WITH_AES_256_CBC_SHA,
       TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,
       TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,
       TLS_DHE_RSA_WITH_AES_128_GCM_SHA256,
       TLS_RSA_WITH_AES_128_CBC_SHA256,
       TLS_RSA_WITH_AES_256_CBC_SHA256"
    />

Comment 5 Endi Sukma Dewata 2017-06-20 15:03:38 UTC
The TomcatJSS changes in comment #2 basically allow the cipher list in server.xml to be specified in multiple lines. It doesn't actually change the server.xml since the file is owned by PKI (although that can be done too in a separate ticket).

To verify this ticket, install PKI CA, modify the cipher list from one long line into multiple lines as shown in the original bug description, restart the CA, and make sure that it is working fine.

Comment 6 Geetika Kapoor 2017-06-21 09:48:32 UTC
Test build:
===========
rpm -qa tomcatjss
tomcatjss-7.2.1-6.el7.noarch

Server.xml changed after setp 1 :

cat b | tr "," "\n" | sed "s/$/,/g"

sslRangeCiphers="-TLS_ECDH_ECDSA_WITH_AES_128_CBC_SHA,
-TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA,
-TLS_ECDH_RSA_WITH_3DES_EDE_CBC_SHA,
-TLS_ECDH_RSA_WITH_AES_128_CBC_SHA,
-TLS_ECDH_RSA_WITH_AES_256_CBC_SHA,
-TLS_ECDH_ECDSA_WITH_AES_256_CBC_SHA,
-TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
-TLS_ECDHE_ECDSA_WITH_3DES_EDE_CBC_SHA,
-TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
-TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
-TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
-TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
-TLS_DHE_DSS_WITH_3DES_EDE_CBC_SHA,
-TLS_DHE_DSS_WITH_AES_128_CBC_SHA,
-TLS_DHE_DSS_WITH_AES_256_CBC_SHA,
-TLS_DHE_RSA_WITH_3DES_EDE_CBC_SHA,
+TLS_DHE_RSA_WITH_AES_128_CBC_SHA,
+TLS_DHE_RSA_WITH_AES_256_CBC_SHA,
+TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,
+TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,
+TLS_DHE_RSA_WITH_AES_128_GCM_SHA256,
-TLS_DHE_DSS_WITH_AES_128_GCM_SHA256,
-TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
-TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,
-TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
-TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
+TLS_RSA_WITH_AES_128_CBC_SHA256,
+TLS_RSA_WITH_AES_256_CBC_SHA256,
-TLS_RSA_WITH_AES_128_GCM_SHA256,
-TLS_RSA_WITH_3DES_EDE_CBC_SHA,
-TLS_RSA_WITH_AES_128_CBC_SHA,
-TLS_RSA_WITH_AES_256_CBC_SHA"

With above mentioned format CA starts well.

Comment 7 errata-xmlrpc 2017-08-01 21:09:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2079