Bug 1457985
| Summary: | Rebalance estimate time sometimes shows negative values | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Nithya Balachandran <nbalacha> | |
| Component: | distribute | Assignee: | Nithya Balachandran <nbalacha> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | amukherj, bugs, rhinduja, rhs-bugs, storage-qa-internal, tdesala | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.13.0 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1454602 | |||
| : | 1460894 1460914 1475399 (view as bug list) | Environment: | ||
| Last Closed: | 2017-09-05 17:33:02 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1454602 | |||
| Bug Blocks: | 1460894, 1460914, 1475399 | |||
|
Description
Nithya Balachandran
2017-06-01 16:54:16 UTC
REVIEW: https://review.gluster.org/17448 (cluster/dht: Include dirs in rebalance estimates) posted (#1) for review on master by N Balachandran (nbalacha) COMMIT: https://review.gluster.org/17448 committed in master by Raghavendra G (rgowdapp) ------ commit c9860430a77f20ddfec532819542bb1d0187c06e Author: N Balachandran <nbalacha> Date: Thu Jun 1 22:13:41 2017 +0530 cluster/dht: Include dirs in rebalance estimates Empty directories were not being considered while calculating rebalance estimates leading to negative time-left values being displayed as part of the rebalance status. Change-Id: I48d41d702e72db30af10e6b87b628baa605afa98 BUG: 1457985 Signed-off-by: N Balachandran <nbalacha> Reviewed-on: https://review.gluster.org/17448 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> Reviewed-by: Raghavendra G <rgowdapp> Moving this back to Post as there is one more patch required. REVIEW: https://review.gluster.org/17564 (cluster/dht: Additional checks for rebalance estimates) posted (#1) for review on master by N Balachandran (nbalacha) COMMIT: https://review.gluster.org/17564 committed in master by Jeff Darcy (jeff.us) ------ commit 426c2908aee4addd36d925ee93e56c9b2688ec1b Author: N Balachandran <nbalacha> Date: Mon Jun 19 11:50:28 2017 +0530 cluster/dht: Additional checks for rebalance estimates The rebalance estimates calculation was not handling calculations correctly when no files had been processed, i.e., when rate_lookedup was 0. Now, the estimated time is set to 0 in such scenarios as there is no way for rebalance to figure out how long the process will take to complete without knowing the rate at which the files are being processed. Change-Id: I7b6378e297e1ba139852bcb2239adf2477336b5b BUG: 1457985 Signed-off-by: N Balachandran <nbalacha> Reviewed-on: https://review.gluster.org/17564 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Amar Tumballi <amarts> Reviewed-by: Raghavendra G <rgowdapp> REVIEW: https://review.gluster.org/17863 (cluster/dht: Fix negative rebalance estimates) posted (#1) for review on master by N Balachandran (nbalacha) REVIEW: https://review.gluster.org/17863 (cluster/dht: Fix negative rebalance estimates) posted (#2) for review on master by N Balachandran (nbalacha) COMMIT: https://review.gluster.org/17863 committed in master by Atin Mukherjee (amukherj) ------ commit e21c915679244ddc1fae886e52badf02b4d95efc Author: N Balachandran <nbalacha> Date: Mon Jul 24 18:27:39 2017 +0530 cluster/dht: Fix negative rebalance estimates The calculation of the rebalance estimates will start after the rebalance operation has been running for 10 minutes. This patch also changes the cli rebalance status code to use unsigned variables for the time calculations. Change-Id: Ic76f517c59ad938a407f1cf5e3b9add571690a6c BUG: 1457985 Signed-off-by: N Balachandran <nbalacha> Reviewed-on: https://review.gluster.org/17863 Reviewed-by: Amar Tumballi <amarts> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Atin Mukherjee <amukherj> CentOS-regression: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.12.0, please open a new bug report. glusterfs-3.12.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-September/000082.html [2] https://www.gluster.org/pipermail/gluster-users/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report. glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html [2] https://www.gluster.org/pipermail/gluster-users/ |