Bug 1458038

Summary: Backup data file is empty due to invalid tar parameters, but still reports success
Product: [Fedora] Fedora Reporter: Ivor Durham <ivor.durham>
Component: MySQL-zrmAssignee: Orion Poplawski <orion>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 25CC: ivor.durham, orion
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: MySQL-zrm-3.0-15.fc25 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-24 04:49:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ivor Durham 2017-06-01 20:07:41 UTC
MySQL-zrm backup fails with the following tar error:

tar: '--same-order' cannot be used with '-c'

which results in a zero-length backup-data file even though the backup reports success!

The log file says: "Command used is 'tar  --same-owner -cpsC ... '"

so the 'c' and 's' tar parameters are incompatible.

Version-Release number of selected component (if applicable):

MySQL-zrm-3.0-11.fc25.noarch
tar-1.29-3.fc25.x86_64

How reproducible:

mysql-zrm.conf contains:

backup-mode=logical
backup-type=regular
destination=/media/backup/mysql-zrm
retention-policy=2M
replication=0
compress=1
compress-plugin=/usr/bin/gzip
encrypt=1
encrypt-plugin="/usr/share/mysql-zrm/plugins/encrypt.pl"
decrypt-option="-d"
all-databases=1
user="XXXXXXXX"
password="XXXXXXXX"
host="localhost"
routines=1
mysql-binpath="/usr/bin"
mysql-binlog-path="/var/log/mariadb"
verbose=0
mailto="XXXXXXXX"
mail-policy=always
passfile="/etc/mysql-zrm/dailyrun/.passphrase"


Steps to Reproduce:
1. Create /etc/mysql-zrm/dailyrun/mysql-zrm.conf as above (adjusting the destination, user, password and mailto accordingly)
2. sudo mysql-zrm-scheduler --now --backup-set dailyrun

Actual results:

Thu Jun 01 10:03:51 2017: dailyrun:backup:INFO: Command used is 'tar  --same-owner -cpsC  "/media/backup/mysql-zrm/dailyrun/20170601100237"  --exclude=backup-data  --exclude=index  --exclude=zrm_checksum . 2>/tmp/N2F79B_zbI  | "/usr/share/mysql-zrm/plugins/encrypt.pl" > "/media/backup/mysql-zrm/dailyrun/20170601100237/backup-data" 2>/tmp/2wY0XMlbX1'
Thu Jun 01 10:03:51 2017: dailyrun:backup:INFO: Output of command: 'tar' is {
tar: '--same-order' cannot be used with '-c'
 Try 'tar --help' or 'tar --usage' for more information.
}

and the backup-data file is empty.

Expected results:

Thu Jun 01 10:47:04 2017: dailyrun:backup:INFO: Command used is 'tar  --same-owner -cpC  "/media/backup/mysql-zrm/dailyrun/20170601104550"  --exclude=backup-data  --exclude=index  --exclude=zrm_checksum . 2>/tmp/pRoBm4bSod  | "/usr/bin/gzip" 2>/tmp/S7CHZRFDfd | "/usr/share/mysql-zrm/plugins/encrypt.pl" > "/media/backup/mysql-zrm/dailyrun/20170601104550/backup-data" 2>/tmp/uCgWejNS2_'
Thu Jun 01 10:48:56 2017: dailyrun:backup:INFO: compress=/usr/bin/gzip

Additional info:

I found a patch for this problem at https://github.com/colinmccune/patches/blob/master/misc/MySQL-ZRM-Common-Fix-Tar-Failing-On-Same-Order-Option.pm.patch

However, the Common.pm file to patch is in /usr/share/perl5/vendor_perl/ZRM/ not /usr/lib/mysql-zrm/ZRM/.

Comment 1 Fedora Update System 2017-06-15 20:23:23 UTC
MySQL-zrm-3.0-15.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-97afc58a48

Comment 2 Fedora Update System 2017-06-18 21:20:19 UTC
MySQL-zrm-3.0-15.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-97afc58a48

Comment 3 Fedora Update System 2017-09-24 04:49:55 UTC
MySQL-zrm-3.0-15.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.