Bug 1458570

Summary:	[brick multiplexing] detach a brick if posix health check thread complaints about underlying brick
Product:	[Community] GlusterFS	Reporter:	Atin Mukherjee <amukherj>
Component:	core	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.11	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1450630	Environment:
Last Closed:	2017-06-28 18:31:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1450630
Bug Blocks:	1450806, 1450813

Description Atin Mukherjee 2017-06-04 13:50:27 UTC

+++ This bug was initially created as a clone of Bug #1450630 +++

Description of problem:

Detach a brick if posix health check thread complaints about underlying brick.


Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
1. Enable brick mux and create a volume with two bricks
2. delete the backend of one of the brick
3. gluster v status doesn't show that brick is disconnected.

Actual results:
brick should be detached and gluster volume status should show the brick as offline.

Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-05-14 03:09:17 EDT ---

REVIEW: https://review.gluster.org/17287 (brick mux: Detach brick on posix health check failure) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-05-14 08:58:51 EDT ---

REVIEW: https://review.gluster.org/17287 (brick mux: Detach brick on posix health check failure) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-05-14 09:49:26 EDT ---

REVIEW: https://review.gluster.org/17287 (brick mux: Detach brick on posix health check failure) posted (#3) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-05-14 12:05:44 EDT ---

REVIEW: https://review.gluster.org/17287 (brick mux: Detach brick on posix health check failure) posted (#4) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-05-15 08:15:07 EDT ---

COMMIT: https://review.gluster.org/17287 committed in master by Jeff Darcy (jeff.us) 
------
commit cb6837d03658c1005475d4040fa95504b3fd84d0
Author: Atin Mukherjee <amukherj>
Date:   Sun May 14 12:34:15 2017 +0530

    brick mux: Detach brick on posix health check failure
    
    With brick mux enabled, we'd need to detach a particular brick if the
    underlying backend has gone bad. This patch addresses the same.
    
    Change-Id: Icfd469c7407cd2d21d02e4906375ec770afeacc3
    BUG: 1450630
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17287
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jeff.us>

Comment 1 Worker Ant 2017-06-04 13:51:45 UTC

REVIEW: https://review.gluster.org/17459 (brick mux: Detach brick on posix health check failure) posted (#1) for review on release-3.11 by Atin Mukherjee (amukherj)

Comment 2 Worker Ant 2017-06-06 13:01:33 UTC

COMMIT: https://review.gluster.org/17459 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 8f79df30c034b303ca86aa4233fd8e899f1da888
Author: Atin Mukherjee <amukherj>
Date:   Sun May 14 12:34:15 2017 +0530

    brick mux: Detach brick on posix health check failure
    
    With brick mux enabled, we'd need to detach a particular brick if the
    underlying backend has gone bad. This patch addresses the same.
    
    >Reviewed-on: https://review.gluster.org/17287
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Jeff Darcy <jeff.us>
    >(cherry picked from commit cb6837d03658c1005475d4040fa95504b3fd84d0)
    
    Change-Id: Icfd469c7407cd2d21d02e4906375ec770afeacc3
    BUG: 1458570
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/17459
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-06-28 18:31:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.1, please open a new bug report.

glusterfs-3.11.1 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-June/000074.html
[2] https://www.gluster.org/pipermail/gluster-users/