Bug 1458580 (php-cilex1)
| Summary: | Review Request: php-cilex1 - PHP micro-framework for Command line tools | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2017-06-21 02:35:38 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1458576 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2017-06-04 14:31:52 UTC
Created attachment 1286379 [details]
phpci.log
phpCompatInfo version 5.0.6 DB version 1.21.0 built Jun 09 2017
07:14:21 CEST static analyze results
Created attachment 1286380 [details]
review.txt
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1458580
Buildroot used: fedora-rawhide-x86_64
[!]: Latest version is packaged.
cilex 1.1.0 => ok packager choise
console-service-provider 1.0.0 => ok for consistency (pimple v1 vs v2)
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
=> please file a upstream bug as even the latest version don't have it
[!]: Final provides and requires are sane (see attachments).
=> missing php-composer(cilex/console-service-provider)
[!]: Requires correct, justified where necessary.
=> php-tokenizer not needed
(only used by Compiler.php which is not packaged)
3rd one is a blocker
(In reply to Remi Collet from comment #3) > [!]: Latest version is packaged. > > cilex 1.1.0 => ok packager choise > console-service-provider 1.0.0 => ok for consistency (pimple v1 vs v2) FYI: cilex 1.1.0 b/c required by phpdoc v2 > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > => please file a upstream bug as even the latest version don't have it I did not do this because v1 is an older version of the lib. v2 does have a license file: https://github.com/Cilex/Cilex/blob/2.0.0/LICENSE > [!]: Final provides and requires are sane (see attachments). > > => missing php-composer(cilex/console-service-provider) bundled(php-cilex-console-service-provider) is provided. Since the lib is bundled, do we really want to provide php-composer(cilex/console-service-provider)? > [!]: Requires correct, justified where necessary. > > => php-tokenizer not needed > (only used by Compiler.php which is not packaged) Will remove after initial import if item above (provides) is deemed not necessary or will remove when I do make that change. > 3rd one is a blocker (In reply to Shawn Iwinski from comment #4) > > [!]: If the source package does not include license text(s) as a separate > > file from upstream, the packager SHOULD query upstream to include it. > > > > => please file a upstream bug as even the latest version don't have it > > I did not do this because v1 is an older version of the lib. v2 does have a > license file: https://github.com/Cilex/Cilex/blob/2.0.0/LICENSE The LICENSE is missing for cilex/console-service-provider (even if probably the same that Cilex main package) > > [!]: Final provides and requires are sane (see attachments). > > > > => missing php-composer(cilex/console-service-provider) > > bundled(php-cilex-console-service-provider) is provided. Since the lib is > bundled, do we really want to provide > php-composer(cilex/console-service-provider)? Yes, I think this is needed. Fixed issues: https://github.com/siwinski/rpms/commit/83d8acfe345d4fb18b05b6de69d4061aeb46c318 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/83d8acfe345d4fb18b05b6de69d4061aeb46c318/php-cilex1/php-cilex1.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-cilex1-1.1.0-2.fc25.src.rpm [x]: Requires correct, justified where necessary.
[x]: Final provides and requires are sane (see attachments).
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
=== APPROVED ===
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-cilex1 php-cilex1-1.1.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd2d6b2d32 php-cilex1-1.1.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd2d6b2d32 php-cilex1-1.1.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. |