Bug 1459181

Summary: [BACKPORT] [Neutron] Don't add duplicate metadata rules after router update
Product: Red Hat OpenStack Reporter: Masaki Furuta ( RH ) <mfuruta>
Component: openstack-neutronAssignee: Brian Haley <bhaley>
Status: CLOSED ERRATA QA Contact: Toni Freger <tfreger>
Severity: medium Docs Contact:
Priority: medium    
Version: 10.0 (Newton)CC: aguetta, amuller, chrisw, dcadzow, ihrachys, jjoyce, nyechiel, oblaut, srevivo
Target Milestone: z4Keywords: FeatureBackport, Triaged, ZStream
Target Release: 10.0 (Newton)   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-neutron-9.4.0-2.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-06 17:17:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Masaki Furuta ( RH ) 2017-06-06 13:21:47 UTC 
Description of problem:
  
- Customer/We still see "Duplicate iptables rule detected" warning messages in l3-agent.log file on OSP10/Newton with 142b68f0 .

- To eliminate it, please introduce upstream fix on https://bugs.launchpad.net/neutron/+bug/1658460 

~~~
commit 1257a3f203aacfbbe16c1afa79893b8b990a1a57
Author: Quan Tian <tianquan>
Date:   Sun Jan 22 16:49:24 2017 +0800

    Don't add duplicate metadata rules after router update
    
    For a HA router, when it's updated, the l3 agents which are standby
    always call the after_router_added method, then duplicate metadata
    rules are added to iptables table. Althrough these rules will not be
    applied to system because of the _weed_out_duplicates method, they will
    grow linearly with router update operations.
    
    Because these metadata rules are added once router is added to the agent
    and will not be cleaned until router is removed, calling the add_rule
    method in after_router_updated is a waste.
    
    This patch removes adding metadata rules in after_router_updated.
    
    Change-Id: I6650f1071499ed6cabd936bb0fb36b32a4b60bca
    Closes-Bug: #1658460
~~~


Version-Release number of selected component (if applicable):
  Red Hat OpenStack Platform 10

How reproducible:
  Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Brian Haley 2017-06-12 15:29:16 UTC 
https://review.openstack.org/#/c/473478/ created.  Once that merges I'll cherry-pick back to 10.0
Comment 4 errata-xmlrpc 2017-09-06 17:17:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2663