Bug 1459251

Summary:	pcs should not guess expected status of a resource when --wait is used
Product:	Red Hat Enterprise Linux 8	Reporter:	Tomas Jelinek <tojeline>
Component:	pcs	Assignee:	Tomas Jelinek <tojeline>
Status:	CLOSED MIGRATED	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	---	CC:	cfeist, cluster-maint, idevat, omular, tojeline
Target Milestone:	rc	Keywords:	MigratedToJIRA, Reopened
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-09 10:04:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1682129
Bug Blocks:

Description Tomas Jelinek 2017-06-06 15:57:13 UTC

Description of problem:
When the --wait flag is used in pcs commands, pcs guesses in what state a resource managed by the command should be when the command finishes. At the end of the command, pcs checks in what state the resource really is and returns 0 if real and expected status matches or 1 if the statuses do not match.

The issue is the expected state of the resource is very hard to get right and that may lead to pcs exiting with a bad return code.


Version-Release number of selected component (if applicable):
pcs-0.9.158-4.el7.x86_64


How reproducible:
always, easily (depending on cluster settings complexity)


Steps to Reproduce:
# pcs resource create test1 ocf:pacemaker:Dummy meta is-managed=false --wait
Error: resource 'test1' is not running on any node
# echo $?
1


Actual results:
pcs exits with 1 because the resource did not start


Expected results:
pcs exits with 0 as the resource was not able to start (pacemaker does not start unmanaged resources) and therefore the command succeeded


Additional info:
With this particular reproducer the issue may seem to be easy to fix in pcs - if the resource is not managed, we expect it not to be started. However more complex setups are possible: the resource may not start due to constraints, utilization, cluster properties and so on and so forth. Also we are not talking about resource create only. Most of the commands supporting --wait are affected.

Comment 1 Tomas Jelinek 2017-06-07 11:32:43 UTC

One way to deal with this is to not make any assumptions of expected resource state. --wait would cause pcs to run crm_resource --wait and print resource status. But pcs exit code would not depend on the resource status. Users would be able to use separate commands to figure out resources' status like described in bz1290830 comment 3.

Comment 7 RHEL Program Management 2020-12-01 07:28:55 UTC

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

Comment 9 RHEL Program Management 2024-01-09 10:00:16 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 10 RHEL Program Management 2024-01-09 10:04:04 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.