Bug 1459681

Summary: rpmscripts for rsyncd.service are in the wrong package :)
Product: [Fedora] Fedora Reporter: Alan Jenkins <alan.christopher.jenkins>
Component: rsyncAssignee: Michal Ruprich <mruprich>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 25CC: code, luhliari, mruprich, ssorce
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rsync-3.1.2-4.fc25 rsync-3.1.2-5.fc26 rsync-3.1.2-4.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-04 01:52:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alan Jenkins 2017-06-07 19:32:42 UTC
$ rpm -q --what-provides /lib/systemd/system/rsyncd.service
rsync-daemon-3.1.2-3.fc25.noarch


$ rpm -q --scripts rsync-daemon | grep rsyncd.service
$ rpm -q --scripts rsync | grep rsyncd.service
        systemctl --no-reload preset rsyncd.service >/dev/null 2>&1 || : 
        systemctl --no-reload disable --now rsyncd.service > /dev/null 2>&1 || : 
        systemctl try-restart rsyncd.service >/dev/null 2>&1 || : 


Steps to Reproduce:
1. dnf install rsync-daemon
2. systemctl enable rsync-daemon
3. dnf remove rsync-daemon
4. ls -l /etc/systemd/system/multi-user.target.wants/rsyncd.service

Actual results:

lrwxrwxrwx. 1 root root 38 Jun  7 20:30 /etc/systemd/system/multi-user.target.wants/rsyncd.service -> /usr/lib/systemd/system/rsyncd.service

Expected results:

ls: cannot access '/etc/systemd/system/multi-user.target.wants/rsyncd.service
': No such file or directory

Comment 1 Alan Jenkins 2017-06-07 19:34:00 UTC
(Reproduction additionally assumes the "rsync" package was installed to begin with, so that it is not removed as a leaf package in step 3).

Comment 2 Michal Ruprich 2017-06-28 13:56:47 UTC
Ok I see, it is missing in the spec file. I will fix that.

Comment 3 Fedora Update System 2017-06-28 19:23:34 UTC
rsync-3.1.2-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8100aed299

Comment 4 Fedora Update System 2017-06-28 19:23:43 UTC
rsync-3.1.2-4.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-92a040da1a

Comment 5 Fedora Update System 2017-06-28 19:23:50 UTC
rsync-3.1.2-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8e092b9210

Comment 6 Alan Jenkins 2017-06-28 22:19:18 UTC
Thanks for looking at this, but I am confused.  rsyncd.service is provided by the rsync-daemon RPM.  Are you going to rebuild rsync-daemon as well to fix the bug I reported?

Comment 7 Fedora Update System 2017-06-29 23:24:32 UTC
rsync-3.1.2-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8e092b9210

Comment 8 Fedora Update System 2017-06-30 01:49:56 UTC
rsync-3.1.2-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8100aed299

Comment 9 Fedora Update System 2017-06-30 02:25:34 UTC
rsync-3.1.2-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-92a040da1a

Comment 10 Michal Ruprich 2017-07-03 06:37:43 UTC
The rsync-daemon is a part of rsync RPM. It is a subpackage... Looking at the latest build in koji the rsync-daemon is rebuilt as well. If you try to download rsync-daemon in Fedora Rawhide, you can see that the latest version is updated as well and the bug is gone.

Comment 11 Alan Jenkins 2017-07-03 07:24:07 UTC
Thanks again!

I had gone as far as `dnf --enablerepo=updates-testing check-update`, but it confuses me by only showing the main package.

I thought I had also looked at installing rsync-daemon, but unless the sub-package was delayed somehow I must have got it wrong.

I made a mistake on Koji as well.  It let me submit negative feedback without logging in, so now I can't see any way to remove it.  I've added the positive feedback to cancel it back to 0.

Comment 12 Michal Ruprich 2017-07-03 07:25:06 UTC
No problem, thanks Alan.

Comment 13 Fedora Update System 2017-07-04 01:52:57 UTC
rsync-3.1.2-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-07-07 23:04:09 UTC
rsync-3.1.2-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2017-07-15 18:49:33 UTC
rsync-3.1.2-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.