Bug 1459914

Summary:	Review Request: python3-poppler-qt5
Product:	[Fedora] Fedora	Reporter:	Gwyn Ciesla <gwync>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mhroncok, package-review, tcallawa
Target Milestone:	---	Flags:	tcallawa: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-15 03:01:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gwyn Ciesla 2017-06-08 14:29:28 UTC

Description:
Python 3 bindings for the Poppler PDF rendering library. It is needed to
run programs written in Python 3 and using Poppler set.

SPEC: https://fedorapeople.org/~limb/review/python3-poppler-qt5/python3-poppler-qt5.spec
SRPM: https://fedorapeople.org/~limb/review/python3-poppler-qt5/python3-poppler-qt5-0.24.2-1.fc26.src.rpm

Needed to upgrade Frescobaldi to 3.0.0.

Comment 1 Tom "spot" Callaway 2017-06-09 18:32:17 UTC

You're missing some rather important BuildRequires, for /usr/bin/sip and poppler-qt5. You can fix that by adding these lines:

BuildRequires: pkgconfig(poppler-qt5)
BuildRequires: sip-devel

A koji scratch build would have caught that immediately. Next time, consider test building your SRPM there first (e.g. koji build --scratch f26-build nameof.src.rpm).

With those two lines added, I finished the review. Please be sure that you add those lines before you commit. :)

== REVIEW ==

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets general and python packaging guidelines
- license (LGPLv2+) OK, matches source (though, you really should ask upstream to include a copy of the LGPLv2 COPYING text, it is missing from their source tree)
- spec file legible, in am. english
- source matches upstream
- package compiles on f26 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

Comment 2 Gwyn Ciesla 2017-06-09 18:43:02 UTC

Thank you!

BEERS_I_OWE_YOU++

Comment 3 Gwyn Ciesla 2017-06-09 18:48:34 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-poppler-qt5

Comment 4 Fedora Update System 2017-06-09 19:39:22 UTC

python3-poppler-qt5-0.24.2-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cea8c5ab4b

Comment 5 Fedora Update System 2017-06-12 04:39:00 UTC

python3-poppler-qt5-0.24.2-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cea8c5ab4b

Comment 6 Miro Hrončok 2017-06-13 14:41:40 UTC

Little late here, but could you please add the python_provide macro?

https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro

Comment 7 Fedora Update System 2017-06-15 03:01:55 UTC

python3-poppler-qt5-0.24.2-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.