Bug 145997
Summary: | hexadecimal integers in user options not accepted | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Steve Friedman <steve> | ||||
Component: | dhcp | Assignee: | Jason Vas Dias <jvdias> | ||||
Status: | CLOSED ERRATA | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 3 | CC: | sundaram | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i386 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-09-05 08:24:59 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 170773, 170776 | ||||||
Attachments: |
|
Description
Steve Friedman
2005-01-24 16:50:29 UTC
Thanks for reporting this bug - I'll develop a fix for Red Hat FC4 + FC3 and submit it to the ISC ASAP . Shortly after I submitted this to bugzilla, I got the following response on the DHCP mailing list: Steve; dhcp-bugs is our bug tracking system. I saw you asked about this on the mailing list, so I opened a ticket and placed you as requestor. This bug looks pretty straightforward; a simple misunderstanding between NUMBER and NUMBER_OR_NAME tokens. We should be able to fix this in the next maintenance release. This bug is now fixed in FC4/Rawhide (see attached patch) and I've compiled it for FC2 and FC3 - you can download it from: http://people.redhat.com/~jvdias/DHCP/FC2 http://people.redhat.com/~jvdias/DHCP/FC2/3.0.2rc3 Created attachment 110152 [details]
patch to common/parse.c fixing hex integer user defined option parse
Correction to Comment #3: http://people.redhat.com/~jvdias/DHCP/FC2/3.0.2rc3 should have been: http://people.redhat.com/~jvdias/DHCP/FC3/3.0.2rc3 I am confused by the patch. It appears to only fix the problem that I reported. However, a quick grep of the dhcp-3.0.2rc3 codebase shows 7 locations (3 in common/parse.c and 4 in server/confparse.c) that check for NUMBER to the exclusion of NUMBER_OR_NAME. Likewise, checking for NAME shows that common/parse.c always checks for NAME or NUMBER_OR_NAME; however, one time in server/confparse.c it checks for both and one time it only checks for NAME. It seems to me that these other matches should be changed as well to fix analogous, latent bugs. Yes, not every integer option may be specified in hex; also we don't allow hex IP address octets. The patch only allows user defined integer options to be specified in hex. The ISC DHCP developer recognizes the problem and is working on a more general purpose fix for the next DHCP maintenance release; when this comes out, it will be integrated with the Red Hat release. Meanwhile, the patch does fix your specific problem. Yes, I can confirm that my specific problem has been resolved. |