Bug 145999

Summary:	5 * dead code
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	parted	Assignee:	Chris Lumens <clumens>
Status:	CLOSED RAWHIDE	QA Contact:	Brock Organ <borgan>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	clausen
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-03-08 18:56:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-01-24 17:27:08 UTC

Description of problem:

I just tried to compile package parted-1.6.21-1 from 
Redhat Fedora development tree.

The compiler said

fdasd.c(650): remark #177: function "fdasd_change_volser" was declared
but never referenced
fdasd.c(228): remark #177: function "fdasd_partition_type" was
declared but never referenced
fdasd.c(357): remark #177: function "fdasd_reread_partition_table" was
declared
but never referenced
count.c(102): remark #177: function "print_chain" was declared but
never referenced
table.c(224): remark #177: function "_test_code_active" was declared
but never referenced

I've had a look at the source code, and I agree with the compiler.
Suggest delete dead code.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Chris Lumens 2005-03-08 18:56:29 UTC

I'm no longer seeing this with the Rawhide gcc and -Wall -Wunused -Werror.

Comment 2 David Binderman 2005-03-09 09:21:02 UTC

>I'm no longer seeing this with the Rawhide gcc and -Wall -Wunused -Werror.

Excellent.

That sounds like a step in the right direction, however there is
no substitute for the Mark 1 eyeball.

I would be grateful if you could confirm visually that these five functions
have really been deleted in the version of the source code you have.

I am unlikely to reach this package for two weeks or more, on the rate
of current progress.