Bug 1460201

Summary: hieradata prepends an invalid comment to UUID when SMBIOS is newer then dmidecode supports
Product: Red Hat OpenStack Reporter: Paul Needle <pneedle>
Component: openstack-tripleo-heat-templatesAssignee: Emilien Macchi <emacchi>
Status: CLOSED ERRATA QA Contact: Gurenko Alex <agurenko>
Severity: medium Docs Contact:
Priority: medium    
Version: 9.0 (Mitaka)CC: aschultz, dbecker, emacchi, mburns, morazi, rhel-osp-director-maint
Target Milestone: Upstream M2Keywords: Triaged, ZStream
Target Release: 14.0 (Rocky)   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-9.0.0-0.20180710202746.d2994ca.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-01-11 11:47:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Paul Needle 2017-06-09 11:08:10 UTC 
Description of problem:

If the SMBIOS of a host is newer than is supported by the installed version of dmidecode, an invalid entry is included before the UUID in a node's heiradata. For example:

---
# SMBIOS implementations newer than version 2.8 are not# fully supported by this version of dmidecode.<UUID>
---

This impacts the pre_deploy per_node.yaml phase of an overcloud deployment because host UUIDs are not valid.

One potential solution could be for dmidecode to be updated prior to running pre_deploy per_node.yaml.

Version-Release number of selected component (if applicable):

* Red Hat OpenStack Platform Director 9.
* dmidecode.

How reproducible:

Every time.

Steps to Reproduce:

1. Run dmidecode on a node where the SMBIOS is newer than that which is supported by the installed version of dmidecode.

2. Perform an overcloud deployment prior to updating dmidecode, which causes issues at the pre_deploy per_node.yaml stage because the UUID is subsequently invalid.

Actual results:

The '#SMBIOS implementations newer than version 2.8 are not# fully supported by this version of dmidecode.' comment is included in the UUID string in hieradata.

Expected results:

For the UUID only to be correctly output to hieradata so that the pre_deploy per_node.yaml phase can reference the correct UUID of a host.
Comment 2 Alex Schultz 2017-06-15 13:33:52 UTC 
The issue is with this line, where i guess dmidecode may return some invalid data depending on the version.

https://github.com/openstack/tripleo-heat-templates/blob/ede56b7a8e2db78513b64996b0a0f5a1ce1904db/puppet/extraconfig/pre_deploy/per_node.yaml#L32
Comment 6 Gurenko Alex 2018-12-17 12:36:58 UTC 
Verified on puddle 2018-12-14.1
openstack-tripleo-heat-templates-9.0.1-0.20181013060905.el7ost.noarch
Comment 8 errata-xmlrpc 2019-01-11 11:47:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:0045