Bug 1460276

Summary: gt fails to build on fast, multi-processor, huge memory machines
Product: [Fedora] Fedora Reporter: Troy Dawson <tdawson>
Component: gtAssignee: Hans de Goede <hdegoede>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: hdegoede
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-06-16 16:00:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to spec file to fix race condition none

Description Troy Dawson 2017-06-09 14:34:30 UTC
Description of problem:
When building gt on a very fast, lots of cpu and memory machine, the builds fail.

Version-Release number of selected component (if applicable):
gt-0.4-23.fc26

How reproducible:
On a very fast, lots of memory, lots of cpu machine, 100%
On a normal desktop or virtual machine, 0%

Steps to Reproduce:
1.
2.
3.

Actual results:
...
gcc -DHAVE_CONFIG_H -I. -I. -I.    -DDEFAULT_PATH=\"/usr/share/timidity\"  -Wall -W -Wshadow -Wpointer-arith -Wcast-align  -I/usr/include -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fsigned-char -c `test -f 'sfz2pat.c' || echo './'`sfz2pat.c
sfz.c:2:0: error: expected '}' at end of input
 #include "sfz2pat.c"
...
In file included from /usr/include/stdio.h:889:0,
                 from readmidi.c:23:
In function 'fread',
    inlined from 'read_midi_file' at readmidi.c:2386:2:
/usr/include/bits/stdio2.h:292:9: warning: call to '__fread_chk_warn' declared with attribute warning: fread called with bigger size * nmemb than length of destination buffer
  return __fread_chk_warn (__ptr, __bos0 (__ptr), __size, __n, __stream);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: Leaving directory '/builddir/build/BUILD/gt-0.4/src'
make[1]: *** [Makefile:232: all] Error 2
make[1]: Leaving directory '/builddir/build/BUILD/gt-0.4/src'
make: *** [Makefile:167: all-recursive] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.ZfQJKh (%build)
    Bad exit status from /var/tmp/rpm-tmp.ZfQJKh (%build)


Expected results:
Package should build successfully

Additional info:
Specs of machine this is failing on.
CPU's: 144 cores - Intel(R) Xeon(R) CPU E7-8860 v4 @ 2.20GHz
Memory: 26 Gig

Comment 1 Troy Dawson 2017-06-09 14:35:49 UTC
We found that making this a single threaded build fixes the problem.
It also doesn't slow the build on normal machines.  (Not enough to notice)

Comment 2 Troy Dawson 2017-06-09 14:40:12 UTC
Created attachment 1286426 [details]
Patch to spec file to fix race condition

Proposed patch to fix the problem.

Comment 3 Troy Dawson 2017-06-16 15:40:55 UTC
This is a blocker for some projects.  We understand some people have limited time to fix packages.  If you do not have the time to fix this, or merge the patch, within two weeks, we will have a proven packager merge the suggested patch in and build it.

Comment 4 Hans de Goede 2017-06-16 16:00:49 UTC
Thank you for the bug-report and the patch.

A fixed package is building for rawhide now, closing.