Bug 1460737

Summary:	rubygem-fluent-plugin-parser: fluentd plugin parser
Product:	[Community] RDO	Reporter:	Juan Badia Payno <jbadiapa>
Component:	Package Review	Assignee:	Matthias Runge <mrunge>
Status:	CLOSED WONTFIX	QA Contact:	hguemar
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	mrunge
Target Milestone:	---	Flags:	mrunge: rdo-review+
Target Release:	trunk
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-08 14:24:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juan Badia Payno 2017-06-12 14:45:34 UTC

SPEC: https://raw.githubusercontent.com/jbadiapa/packages/master/rubygem-fluent-plugin-parser/rubygem-fluent-plugin-parser.spec

SRPM: https://github.com/jbadiapa/packages/raw/master/rubygem-fluent-plugin-parser/rubygem-fluent-plugin-parser-0.6.1-1.el7.centos.src.rpm


Used this configuration for mock: 
https://github.com/jbadiapa/packages/blob/master/helperScripts/mock-jbp-centos-7-base-x86_64.cfg

The output of the fedora-review can be found:
https://github.com/jbadiapa/packages/blob/master/rubygem-fluent-plugin-parser/review.txt

Comment 1 Matthias Runge 2017-06-15 09:34:25 UTC

this looks ok to me, please change the requires from rubygem-oj to rubygem(oj).

This here should fix the missing provides: https://review.rdoproject.org/r/#/c/7070/

Comment 2 Juan Badia Payno 2017-06-19 07:18:18 UTC

Fixed the rubygem-oj to rubygem(oj)

Added some dependencies that were missed.

Comment 3 Matthias Runge 2017-06-19 08:20:51 UTC

note, there is no rubygem-rake, no rubygem-bundler, and no rubygem-json in cbs yet.

Comment 4 Juan Badia Payno 2017-07-06 06:52:01 UTC

The three packages are on centos 7 base repository, at least I could see them on:
[vagrant@rpmbuild ~]$ yum list rubygem* | egrep -e json -e rake -e bundler 
rubygem-bundler.noarch               1.7.8-3.el7        @base                   
rubygem-json.x86_64                  1.7.7-29.el7       @base                   
rubygem-rake.noarch                  0.9.6-29.el7       @base 
Note: my base repo points at mirrorlist=http://mirrorlist.centos.org/?release=$releasever&arch=$basearch&repo=os&infra=$infra

I could see them on cbs as:
rubygem-bundler -- http://cbs.centos.org/koji/rpminfo?rpmID=59525
rubygem-json    -- http://cbs.centos.org/koji/search?match=glob&type=rpm&terms=rubygem-json*
rubygem-rake    -- http://cbs.centos.org/koji/search?match=glob&type=rpm&terms=rubygem-rake*

Comment 5 Matthias Runge 2017-07-06 14:45:53 UTC

Since you want to have this built against all 0.12.x versions, make the requirement
BuildRequires: fluentd < 0.12.31
more something like
(either)
BuildRequires: fluentd 
or 
BuildRequires: fluentd < 0.13

There won't be a fluentd > 0.12.x any time soon in cbs, I guess. 

Otherwise looks good, the license specified is correct. Please fix the BuildRequires during import.

Comment 6 Matthias Runge 2017-07-08 15:53:16 UTC

https://review.rdoproject.org/r/#/c/7478/