Bug 1460960

Summary:	ISE on ProxyClients page
Product:	Red Hat Satellite 5	Reporter:	Ales Dujicek <adujicek>
Component:	Server	Assignee:	Gennadii Altukhov <galtukho>
Status:	CLOSED ERRATA	QA Contact:	Pavel Studeník <pstudeni>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	580	CC:	galtukho, jdobes, mkorbel, pstudeni, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spacewalk-java-2.5.14-101-sat	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-19 11:57:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1450111

Description Ales Dujicek 2017-06-13 09:08:04 UTC

Description of problem:

System -> Details > Proxy (/rhn/systems/details/ProxyClients.do?sid=1000010007&) page
causes ISE when sid=* is not a proxy

on 5.7 (/network/systems/details/proxy.pxt) it shows this message:
Proxy
WebUI Spacewalk Proxy installer is obsoleted since version 5.3. Please use command line installer from package spacewalk-proxy-installer.

but on 5.8 you get
Internal Server Error 

catalina.out:
2017-06-13 04:33:12,209 [TP-Processor3] ERROR com.redhat.rhn.frontend.servlets.SessionFilter - Error during transaction. Rolling back
javax.servlet.ServletException: javax.servlet.jsp.JspException: Request attribute 'parentUrl' must be set.
	at org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:862)
	at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:791)
	at org.apache.jsp.WEB_002dINF.pages.systems.sdc.proxyclients_jsp._jspService(Unknown Source)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:646)
	at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:436)
	at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:374)
	at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:302)
	at org.apache.struts.action.RequestProcessor.doForward(RequestProcessor.java:1083)
	at org.apache.struts.action.RequestProcessor.processForwardConfig(RequestProcessor.java:396)
	at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:232)
	at com.redhat.rhn.frontend.struts.RhnRequestProcessor.process(RhnRequestProcessor.java:105)
	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
	at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:449)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at com.redhat.rhn.frontend.servlets.AuthFilter.doFilter(AuthFilter.java:127)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at com.opensymphony.sitemesh.webapp.SiteMeshFilter.obtainContent(SiteMeshFilter.java:129)
	at com.opensymphony.sitemesh.webapp.SiteMeshFilter.doFilter(SiteMeshFilter.java:77)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at com.redhat.rhn.frontend.servlets.LocalizedEnvironmentFilter.doFilter(LocalizedEnvironmentFilter.java:67)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at com.redhat.rhn.frontend.servlets.EnvironmentFilter.doFilter(EnvironmentFilter.java:101)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at com.redhat.rhn.frontend.servlets.SessionFilter.doFilter(SessionFilter.java:57)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at com.redhat.rhn.frontend.servlets.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:97)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:299)
	at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:190)
	at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
	at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:769)
	at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:698)
	at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:891)
	at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:690)
	at java.lang.Thread.run(Thread.java:785)
Caused by: 
javax.servlet.jsp.JspException: Request attribute 'parentUrl' must be set.
	at com.redhat.rhn.frontend.taglibs.list.ListSetTag.verifyEnvironment(ListSetTag.java:139)
	at com.redhat.rhn.frontend.taglibs.list.ListSetTag.doStartTag(ListSetTag.java:98)
	at org.apache.jsp.WEB_002dINF.pages.systems.sdc.proxyclients_jsp._jspx_meth_rl_005flistset_005f0(Unknown Source)
	at org.apache.jsp.WEB_002dINF.pages.systems.sdc.proxyclients_jsp._jspx_meth_html_005fhtml_005f0(Unknown Source)
	... 51 more



Version-Release number of selected component (if applicable):
spacewalk-java-2.5.14-89.el6sat.noarch

How reproducible:
always

Steps to Reproduce:
1. sync proxy channel
2. register rhel6 system
3. add provisioning entitlement
3. System -> Details > Proxy (/rhn/systems/details/ProxyClients.do?sid=1000010007&)

Actual results:
ISE

Comment 1 Gennadii Altukhov 2017-06-27 09:57:25 UTC

the bug is fixed in upstream. spacewalk.git:
5dbced7ed4d4a976fe1ebf6ed3ca05f5fc9772aa

Comment 2 Gennadii Altukhov 2017-06-27 11:49:44 UTC

*** Bug 1455476 has been marked as a duplicate of this bug. ***

Comment 5 Pavel Studeník 2017-09-12 10:48:44 UTC

Verified with spacewalk-java-lib-2.5.14-97.el6sat.noarch

Reproducer is same as Description

Comment 6 Martin Korbel 2017-09-26 13:28:48 UTC

FAILQA  on spacewalk-java-2.5.14-98.

The button arrows ">" or ">>" (next page) returns "Permission Error" page.
We get the same situation, when we try to switch number of items in table.

> /var/log/tomcat*/catalina.out   
2017-09-26 09:24:10,969 [TP-Processor6] ERROR org.apache.struts.action.RequestProcessor - Missing Acl: user_role(org_admin); system_is_proxy(); not system_is_satellite() when accessing /rhn/systems/details/ProxyClients.do

Comment 7 Gennadii Altukhov 2017-10-04 13:07:45 UTC

The second issue from comment #6 fixed in upstream. spacewalk.git:
79780b1d41d8cd5226fe0c8bee59e2b8790199ed

Comment 11 Gennadii Altukhov 2017-10-12 09:04:31 UTC

additional fix in upstream, spacewalk.git:
9148283f88ceed096eb5450fe5d67c52c3686d27

Comment 14 Pavel Studeník 2017-10-12 12:51:33 UTC

Verified with spacewalk-java-2.5.14-101.el6sat.noarch

Comment 16 errata-xmlrpc 2017-10-19 11:57:19 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2915