Bug 1461069

Summary: Fix for failing tests of websocketpp 0.7.0-6, test_permessage_deflate, test_transport, test_transport_asio_timers
Product: [Fedora] Fedora Reporter: c72578
Component: websocketppAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: c72578, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: websocketpp-0.7.0-7.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-07 23:01:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix build and test failures with zlib 1.2.11. Fixes test_permessage_deflate
none
minor adjustments to recent extension negotiation related fixes
none
Disable tests transport-test and transport_asio_timers none

Description c72578 2017-06-13 13:02:36 UTC
Description of problem:
- Up to now, a test of websocketpp 0.7.0-6 is always failing.
3 - test_permessage_deflate (Failed)
See:
https://kojipkgs.fedoraproject.org//packages/websocketpp/0.7.0/6.fc27/data/logs/noarch/build.log

- Upstream, the issue "build and testsuite failures with zlib 1.2.11" has been fixed recently:
https://github.com/zaphoyd/websocketpp/issues/653

Using the following two commits
https://github.com/zaphoyd/websocketpp/commit/9ddb300d874a30db35e3ad58f188944bef0bf31b
https://github.com/zaphoyd/websocketpp/commit/4cab5e5c0c5f19fcee7d37b4a38b156d63a150d4

The two patches, which have been backported to websocketpp 0.7.0 are attached to this bug report
websocketpp-0.7.0-zlib-permessage-deflate.patch
websocketpp-0.7.0-minor-adjustments-to-recent-extension-negotiation.patch

- Furthermore, the following two tests are occasionally failing:
test_transport, test_transport_asio_timers

A patch, which disables these two tests, is attached to this bug report.
websocketpp-0.7.0-disable-test_transport-test_transport_asio_timers.patch

Version-Release number of selected component (if applicable):
0.7.0-6

How reproducible:
Always


Additional info:
An updated spec file can be found here:
Spec URL: https://raw.githubusercontent.com/c72578/rpmbuild/master/SPECS/websocketpp.spec

* Tue Jun 13 2017 Wolfgang Stöggl <c72578> - 0.7.0-7
- Add patches to fix zlib test failure (test_permessage_deflate)
- Disable tests test_transport, test_transport_asio_timers

Fedora copr test builds of 0.7.0-7 are here:
https://copr.fedorainfracloud.org/coprs/c72578/websocketpp/

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/c72578/websocketpp/fedora-rawhide-x86_64/00564734-websocketpp/websocketpp-0.7.0-7.fc27.src.rpm

Comment 1 c72578 2017-06-13 13:57:43 UTC
Created attachment 1287293 [details]
Fix build and test failures with zlib 1.2.11. Fixes test_permessage_deflate

Backported to websocketpp 0.7.0 from:
https://github.com/zaphoyd/websocketpp/commit/9ddb300d874a30db35e3ad58f188944bef0bf31b

Comment 2 c72578 2017-06-13 14:01:24 UTC
Created attachment 1287295 [details]
minor adjustments to recent extension negotiation related fixes

Backported to websocketpp 0.7.0 from:
https://github.com/zaphoyd/websocketpp/commit/4cab5e5c0c5f19fcee7d37b4a38b156d63a150d4

Comment 3 c72578 2017-06-13 14:02:45 UTC
Created attachment 1287297 [details]
Disable tests transport-test and transport_asio_timers

Disable the following tests, which fail occasionally:
test_transport, test_transport_asio_timers

Comment 4 Rex Dieter 2017-06-14 16:00:14 UTC
would you be interested in becoming a fedora package co-maintainer?  If so, I'm wililng to give you commit access, and make the changes yourself.

Comment 5 c72578 2017-06-16 04:47:22 UTC
Thank you very much for the offer to become co-maintainer. Yes, I am very happy to contribute and make changes myself.

Comment 6 Rex Dieter 2017-06-16 14:41:39 UTC
OK, what's your FAS username?  c72578 ?

Comment 7 Rex Dieter 2017-06-16 14:42:43 UTC
In short, I can offer to sponsor you into the packagers group, so that you can comaintain this package.

Comment 8 c72578 2017-06-16 21:41:53 UTC
Thanks a lot. Yes, my FAS username is c72578

Comment 9 Rex Dieter 2017-06-17 16:38:52 UTC
commit acl's granted, feel free to contact me if you have any questions or need help or whatever.

Comment 10 Fedora Update System 2017-06-27 08:25:37 UTC
websocketpp-0.7.0-7.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6e25ccb51

Comment 11 Fedora Update System 2017-06-27 20:26:44 UTC
websocketpp-0.7.0-7.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b6e25ccb51

Comment 12 Fedora Update System 2017-07-07 23:01:34 UTC
websocketpp-0.7.0-7.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.