Bug 1461183

Summary:	Service catalog service dialog refresh function in cf 4.2 behaves differently from cf 4.0
Product:	Red Hat CloudForms Management Engine	Reporter:	Satoe Imaishi <simaishi>
Component:	Automate	Assignee:	eclarizi
Status:	CLOSED ERRATA	QA Contact:	Shveta <sshveta>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.7.0	CC:	eclarizi, jhardy, lcouzens, mfeifer, mkanoor, myoder, obarenbo, rspagnol, simaishi, tfitzger
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.8.1
Hardware:	All
OS:	All
Whiteboard:	upgrade:service:dialog
Fixed In Version:	5.8.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1439761	Environment:
Last Closed:	2017-08-02 17:31:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1439761
Bug Blocks:

Comment 2 CFME Bot 2017-06-13 22:23:26 UTC

New commit detected on ManageIQ/manageiq-ui-classic/fine:
https://github.com/ManageIQ/manageiq-ui-classic/commit/af0ceeb8faba835d46c6c8f06ba567bfb395951f

commit af0ceeb8faba835d46c6c8f06ba567bfb395951f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon May 22 14:46:31 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Jun 13 18:17:53 2017 -0400

    Merge pull request #1349 from eclarizio/BZ1439761
    
    Fix for service catalog service dialog refresh function behaving differently
    (cherry picked from commit cbdfa50fb06d68dd07e1e9796c977d9524f6ecb8)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461183

 app/assets/javascripts/dialog_field_refresh.js     |  39 ++-
 app/helpers/application_helper/dialogs.rb          |   3 +-
 .../dialogs/_auto_refresh_javascript.html.haml     |   9 +
 .../dialogs/_dialog_field_check_box.html.haml      |  19 +-
 ...alog_field_date_and_date_time_control.html.haml |  19 +-
 .../dialogs/_dialog_field_drop_down_list.html.haml |  23 +-
 .../dialogs/_dialog_field_radio_button.html.haml   |  27 +-
 .../dialogs/_dialog_field_text_area_box.html.haml  |  21 +-
 .../dialogs/_dialog_field_text_box.html.haml       |  23 +-
 spec/helpers/application_helper/dialogs_spec.rb    |  21 +-
 spec/javascripts/dialog_field_refresh_spec.js      | 301 ++++++++++++++++++---
 11 files changed, 387 insertions(+), 118 deletions(-)
 create mode 100644 app/views/shared/dialogs/_auto_refresh_javascript.html.haml

Comment 3 CFME Bot 2017-06-14 15:43:12 UTC

New commit detected on ManageIQ/manageiq-ui-service/fine:
https://github.com/ManageIQ/manageiq-ui-self_service/commit/7e41b7c23df5b8536897a3c67c9314c5e47b624c

commit 7e41b7c23df5b8536897a3c67c9314c5e47b624c
Author:     Chris Kacerguis <chriskacerguis.github.com>
AuthorDate: Mon Jun 12 10:21:32 2017 -0500
Commit:     Satoe Imaishi <simaishi>
CommitDate: Wed Jun 14 11:40:52 2017 -0400

    Merge pull request #814 from eclarizio/BZ1439761
    
    Fix for service catalog service dialog refresh function behaving differently
    (cherry picked from commit 8c8cd0b39386187a01d72b6076b016e8f1322348)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461183

 client/app/core/auto-refresh.service.js            |  44 ++++++++
 client/app/core/auto-refresh.service.spec.js       |  61 +++++++++++
 client/app/core/core.module.js                     |   2 +
 client/app/core/dialog-field-refresh.service.js    |  83 +++++++-------
 .../app/core/dialog-field-refresh.service.spec.js  | 121 +++++++++++----------
 .../app/states/catalogs/details/details.state.js   |   7 +-
 .../states/catalogs/details/details.state.spec.js  |  33 ++++--
 .../custom_button_details.state.js                 |   7 +-
 .../custom_button_details.state.spec.js            |  33 ++++--
 .../services/reconfigure/reconfigure.state.js      |   9 +-
 .../services/reconfigure/reconfigure.state.spec.js |  34 ++++--
 11 files changed, 293 insertions(+), 141 deletions(-)
 create mode 100644 client/app/core/auto-refresh.service.js
 create mode 100644 client/app/core/auto-refresh.service.spec.js

Comment 4 Marianne Feifer 2017-06-23 16:11:27 UTC

Should this be moved to post?  (Still learning the "rules")

Comment 5 luke couzens 2017-06-27 08:25:04 UTC

Changing summary because this is not directly related to migration.

Comment 6 Shveta 2017-06-30 16:10:31 UTC

Fixed in 5.8.1.0.20170623170756_3ed4411 .
Dynamic fields auto-refresh other fields when modified.

Comment 8 errata-xmlrpc 2017-08-02 17:31:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:1758