Bug 1461702

Summary: [trello yy3ACVjj]Should display new Bitbucket and Gitlab webhooks url on the bc configuration page
Product: OpenShift Container Platform Reporter: shahan <hasha>
Component: Management ConsoleAssignee: Jessica Forrester <jforrest>
Status: CLOSED CURRENTRELEASE QA Contact: XiaochuanWang <xiaocwan>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.0CC: aos-bugs, jokerman, mmccomas, smunilla, spadgett, wrichter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-07-25 14:03:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Configuration tab
none
unstable issue none

Description shahan 2017-06-15 08:45:53 UTC 
Created attachment 1287957 [details]
Configuration tab

Description of problem:
Should display new type webhooks url on the bc configuration page

Version-Release number of selected component (if applicable):
OpenShift Master:v3.6.109
Kubernetes Master:v1.6.1+5115d708d7 

How reproducible:
Always

Steps to Reproduce:
1.Login in web console 
2.Create an bc
# oc new-build openshift/ruby:latest --code=http://github.com/openshift/ruby-
hello-world.git
3.Go to ruby-hello-world bc edit page, add new type webhooks: add 'Bitbucket'  and 'Gitlab' webhooks under the drop-down list
4.Check Configuration tab of bc page

Actual results:
4.No display url of the new type webhooks and 'Lear more' link,It just display:
Other Trigger:GitLab/ Other Trigger:Bitbucket

Expected results:
4.Should display the URL and 'learn more' link as Github/Generic webhooks

Additional info:
Comment 1 Jessica Forrester 2017-06-15 17:25:13 UTC 
This is being fixed in https://github.com/openshift/origin-web-console/pull/1720

It will properly display the webhook URLs for the new types now.  Instead of having a bunch of individual learn more links, which looked cluttered, we decided to have the Learn More link move up to the Triggers header and point to the build triggers page.
Comment 2 openshift-github-bot 2017-06-16 14:01:01 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/287fb70d559f9e0b7082a24a6bb3113a7ef48005
Bug 1461702 - Fix display of build webhooks to support new types

Also fixes outdated documentation links.
Comment 3 shahan 2017-06-21 08:09:18 UTC 
Checked this issue in openshift v3.6.121, the bug was fixed. After add new Bitbucket and Gitlab webhooks, could display these webhooks url and just have Learn more link beside the Triggers header. So, could you change this bug status to ON_QA? Thanks!
Comment 5 shahan 2017-06-23 11:23:34 UTC 
 The issue is indeed verified in the last comment, but found the new unstable issue: after adding some webhooks in BC editor, the Configuration tab sometimes can show triggers correctly but sometimes cannot. E.g. add Bitbucket webhook, Save, check Configuration tab, it is correct. Add another Github webhook, Save, check Configuration tab, it is wrong now. See video record
Comment 6 shahan 2017-06-23 11:32:40 UTC 
Created attachment 1290980 [details]
unstable issue
Comment 7 Jessica Forrester 2017-06-23 16:42:53 UTC 
New issue fixed in https://github.com/openshift/origin-web-console/pull/1763
Comment 8 Jessica Forrester 2017-06-26 12:11:01 UTC 
*** Bug 1464600 has been marked as a duplicate of this bug. ***
Comment 10 shahan 2017-06-29 02:41:27 UTC 
Test this issue against openshift v3.6.126.1, it was fixed. Besides, checked other add/remove orders, feature works well.