Bug 1461861

Summary: notification background is incorrect in GNOME Classic
Product: [Fedora] Fedora Reporter: David Demelier <markand>
Component: gnome-shellAssignee: Owen Taylor <otaylor>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 26CC: andrea.vai, bartmon, bnater, fmuellner, jmarchan, jolee, kfiresmith, lgustafson907, mathieu, mkoch, mreynolds, otaylor, t.j.bentley
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1574407 (view as bug list) Environment:
Last Closed: 2018-05-29 12:31:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot
none
Screenshot of the message tray none

Description David Demelier 2017-06-15 13:06:34 UTC
Created attachment 1288059 [details]
screenshot

Description of problem:

Using GNOME Classic, the notification background looks incorrect and the foreground color is unreadable.

Steps to Reproduce:

1. Use adwaita default theme and GNOME Classic.
2. Launch any notification using notify-send hello

Actual results:

Black on black colors.

Expected results:

Something readable like in stock GNOME. Probably a CSS issue.

Comment 1 Jerome Marchand 2017-07-19 15:32:38 UTC
Same issue with the message tray. The "Clear all" button at the bottom is totally illegible (the very same shade of light grey it seems). It's barely legible when the mouse hover the button (white on light grey). 

Gnome classic, fresh install.

Comment 2 Jerome Marchand 2017-07-19 15:33:53 UTC
Created attachment 1301171 [details]
Screenshot of the message tray

Comment 3 Jerome Marchand 2017-07-24 13:06:55 UTC
In the mean time, is there a workaround? Can we set the color of notification somehow?

Comment 4 Jerome Marchand 2017-07-26 12:48:34 UTC
(In reply to Jerome Marchand from comment #3)
> In the mean time, is there a workaround? Can we set the color of
> notification somehow?

This is is really annoying, so I dug a bit. I came to to following file:
/usr/share/gnome-shell/theme/gnome-classic.css

It contains a section for the notification banner:

.notification-banner {
  font-size: 11pt;
  width: 34em;
  margin: 5px;
  border-radius: 6px;
  color: #eeeeec;
  background-color: #2e3436;
  border: 1px solid #a1a1a1; }
  .notification-banner:hover {
    background-color: #2e3436; }
  .notification-banner:focus {
    background-color: #2e3436; }

See the dark background colors above. I don't know what determines the color of the text itself (currently black), so I made a custom theme that only redefines  the background with a lighter color and it seems to work.

Comment 5 Branislav Náter 2017-10-14 08:53:20 UTC
Hi, this seems to be still issue. Any progress here?

Comment 6 Andrea Vai 2017-11-15 10:55:20 UTC
I am also experiencing this annoying bug, Gnome 3.24 on Fedora 26.

Comment 7 Branislav Náter 2017-11-20 17:16:37 UTC
And also with gnome-shell-3.26.2-1.fc27 on Fedora 27.

Comment 8 Jaša Bartelj 2017-12-13 20:58:43 UTC
Upstream issue:
https://bugzilla.gnome.org/show_bug.cgi?id=783826

Jerome Marchand, thank you for locating the CSS property. I'll modify it manually as the users I support are complaining.

Comment 9 Kodiak Firesmith 2018-02-19 14:43:18 UTC
It seems fairly absurd that this is still a problem in RHEL 7.  I'll submit a customer support request to see if they plan on fixing such an ugly UI problem on their flagship product.

Comment 10 Kodiak Firesmith 2018-02-19 14:48:40 UTC
Created 02038090 to try to get someone to field the issue.

Comment 11 Markus Koch 2018-04-20 15:18:14 UTC
Guys, I had the same problem with Fedora 27.
Here is my patch that makes it readable:

*** gnome-classic.css	2018-04-20 14:58:12.105081356 +0200
--- gnome-classic.css_dist	2018-03-19 14:40:49.072505704 +0100
***************
*** 901,910 ****
    width: 31.5em; }
  
  .message-list-clear-button.button {
!   background-color: #b6b6b6;
    margin: 1.5em 1.5em 0; }
    .message-list-clear-button.button:hover, .message-list-clear-button.button:focus {
!     background-color: #929292; }
  
  .message-list-sections {
    spacing: 1em; }
--- 901,910 ----
    width: 31.5em; }
  
  .message-list-clear-button.button {
!   background-color: transparent;
    margin: 1.5em 1.5em 0; }
    .message-list-clear-button.button:hover, .message-list-clear-button.button:focus {
!     background-color: #fafafa; }
  
  .message-list-sections {
    spacing: 1em; }
***************
*** 1370,1381 ****
    margin: 5px;
    border-radius: 6px;
    color: #eeeeec;
!   background-color: #a1a1a1;
!   border: 1px solid #2e0000; }
    .notification-banner:hover {
!     background-color: #b6b6b6; }
    .notification-banner:focus {
!     background-color: #929292; }
    .notification-banner .notification-icon {
      padding: 5px; }
    .notification-banner .notification-content {
--- 1370,1381 ----
    margin: 5px;
    border-radius: 6px;
    color: #eeeeec;
!   background-color: #2e3436;
!   border: 1px solid #a1a1a1; }
    .notification-banner:hover {
!     background-color: #2e3436; }
    .notification-banner:focus {
!     background-color: #2e3436; }
    .notification-banner .notification-icon {
      padding: 5px; }
    .notification-banner .notification-content {

Best Regards
 Markus

Comment 12 Markus Koch 2018-04-20 15:46:47 UTC
As the bug still exist in F27, can somebody please add the official fixes from here: https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/26

Comment 13 Fedora End Of Life 2018-05-03 08:11:52 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 14 Andrea Vai 2018-05-03 08:43:57 UTC
Cloning to Bug #1574407, and assigning version 27 there, because it affects F27 and I cannot change version here (please explain if I should have made it a better way, thx)

Comment 15 Fedora End Of Life 2018-05-29 12:31:10 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.