Bug 1461932
| Summary: | Upload image UI shows "C:\fakepath\disk_name" after selecting a disk to be uploaded in Chrome (55 and 59) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Natalie Gavrielov <ngavrilo> | ||||
| Component: | Frontend.WebAdmin | Assignee: | Daniel Erez <derez> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Natalie Gavrielov <ngavrilo> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.2.0 | CC: | amureini, bugs, derez, ehildesh, ngavrilo, ylavi | ||||
| Target Milestone: | ovirt-4.2.0 | Flags: | rule-engine:
ovirt-4.2+
|
||||
| Target Release: | 4.2.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | No Doc Update | |||||
| Doc Text: |
undefined
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 1474585 1474590 (view as bug list) | Environment: | |||||
| Last Closed: | 2017-12-20 11:14:34 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Does this happen in 4.1.z too? It's actually a standard security measure of HTML5 [1]. The path could be revealed by configuring the browser's settings: https://www.nextofwindows.com/how-to-get-rid-of-cfakepath-in-ie-when-uploading-a-file-to-the-website-fix @Allon - do we want to find some hack to remove this even though it's by html design? E.g. https://stackoverflow.com/questions/21426232/how-to-remove-c-fakepath-in-webkit-browser-like-chrome-safari-opera [1] "According to the specifications of HTML5, a file upload control should not reveal the real local path to the file you have selected, if you manipulate its value string with JavaScript. Instead, the string that is returned by the script, which handles the file information is c:\fakepath." [https://acidmartin.wordpress.com/2009/06/09/the-mystery-of-cfakepath-unveiled/] (In reply to Daniel Erez from comment #2) > @Allon - do we want to find some hack to remove this even though it's by > html design? This is a PM question, but my gut instinct is to close this as NOTABUG. Yaniv? (In reply to Allon Mureinik from comment #3) > (In reply to Daniel Erez from comment #2) > > @Allon - do we want to find some hack to remove this even though it's by > > html design? > This is a PM question, but my gut instinct is to close this as NOTABUG. > Yaniv? Maybe we should not display the path at all. I think just the file name or some checkbox would work better. UX should probably be consulted. (In reply to Yaniv Lavi from comment #4) > (In reply to Allon Mureinik from comment #3) > > (In reply to Daniel Erez from comment #2) > > > @Allon - do we want to find some hack to remove this even though it's by > > > html design? > > This is a PM question, but my gut instinct is to close this as NOTABUG. > > Yaniv? > > Maybe we should not display the path at all. > I think just the file name or some checkbox would work better. > UX should probably be consulted. Eldan, your two cents? I don't really see a reason to show the full path unless we keep it for future purposes, so from my point of view: Show only the file name, no path. (In reply to Eldan Hildesheim from comment #6) > I don't really see a reason to show the full path unless we keep it for > future purposes, so from my point of view: Show only the file name, no path. Agreed. Daniel - let's do that please. I'm glad that you all came to the conclusion that it's best to show the filename only (which was the behavior in previous versions, such as 4.1) and not closing this as not a bug. I somehow feel that none of you guys read the expected result in the description of the bug. Here it is: Expected results: Just the filename (no C:\fakepath prefix) Just saying.. Daniel - the patch is merged. Is there anything else we're waiting for here, or should it be moved to MODIFIED? Verified with Chrome 59 and 60. Build used: ovirt-engine-4.2.0-0.0.master.20170828065003.git0619c76.el7.centos.noarch This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1288111 [details] engine.log, ui.log, server.log, image-proxy.log, snapshots from Chrome 55 and Chrome 59 Description of problem: When selecting a disk to be uploaded, UI shows "C:\fakepath\" + file chosen, instead of just the file chosen for Chrome 55 and 59 (Firefox works fine showing the file name only). Snapshots attached. Version-Release number of selected component: ovirt-engine-4.2.0-0.0.master.20170606135217.gita02bf9d.el7.centos.noarch ovirt-imageio-proxy-1.0.0-0.201706060741.git25ceb73.el7.centos.noarch ovirt-imageio-common-1.0.0-0.201706060741.git25ceb73.el7.centos.noarch and ovirt-engine-4.2.0-0.0.master.20170612192318.gitf773263.el7.centos.noarch ovirt-imageio-proxy-1.0.0-0.201705101937.git911f423.el7.centos.noarch ovirt-imageio-common-1.0.0-0.201705101937.git911f423.el7.centos.noarch How reproducible: 100% Steps to Reproduce: 1. Go to webadmin -> Disks tab 2. Click on Upload -> Start 3. Choose File Actual results: File chosen is displayed in the UI the following way: C:\fakepath\the_filename Expected results: Just the filename (no C:\fakepath prefix) Additional info: Tested with two Chrome versions: 55 and 59: - For 55, the upload is blocked and shows the following message: "The selected file cannot be opened". - For 59 version there is no such message, and regardless, upload doesn't work because of a bug found for Chrome 58