Bug 1462296
| Summary: | oci-register-machine fails on s390x, because godbus sends only little endian messages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Dan Horák <dhorak> | ||||
| Component: | oci-register-machine | Assignee: | Frantisek Kluknavsky <fkluknav> | ||||
| Status: | CLOSED ERRATA | QA Contact: | atomic-bugs <atomic-bugs> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 7.3 | CC: | dwalsh, jjarvis, lsm5, qcai, yselkowi | ||||
| Target Milestone: | rc | Keywords: | Extras | ||||
| Target Release: | --- | ||||||
| Hardware: | s390x | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | oci-register-machine-0-3.12.gitcbf1b8f.el7 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-10-19 15:18:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1425142, 1477926, 1478982, 1480422 | ||||||
| Attachments: |
|
||||||
|
Description
Dan Horák
2017-06-16 16:04:05 UTC
Created attachment 1289068 [details] temporary fix a scratch build with the patch applied https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13465803 Container registration with systemd/machined now works OK. My https://github.com/godbus/dbus/pull/86 PR got upstream attention, so we should get an accepted fix soon. the godbus fix is now https://github.com/godbus/dbus/commit/37252881b3a87eaa2eb04b0ff2211f54f45199ab I've asked about updating standalone golang-github-godbus-dbus package in Fedora in bug 1463511, but we also need the godbus bundled with oci-register-machine to be updated. Dan could you verify that https://github.com/projectatomic/oci-register-machine/pull/31 fixes your issues? Dan I vendored inot oci-register-machine the new go-dbus bindings. oci-register-machine-0-3.9.git76fc0b3.fc27 is building in Rawhide Lokesh can you build a new version for RHEL7.4 release. I've tried a build with updated source archive and it's failing to build - https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13659994 from build.log ... Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.4xgrte + umask 022 + cd /builddir/build/BUILD + cd oci-register-machine-76fc0b3e8cb7f838fe852b8a5b61920db2c05920 + mkdir -p src/github.com/projectatomic + ln -s ../../../ src/github.com/projectatomic/oci-register-machine ++ pwd ++ pwd + export GOPATH=/builddir/build/BUILD/oci-register-machine-76fc0b3e8cb7f838fe852b8a5b61920db2c05920:/builddir/build/BUILD/oci-register-machine-76fc0b3e8cb7f838fe852b8a5b61920db2c05920/Godeps/_workspace:/usr/share/gocode + GOPATH=/builddir/build/BUILD/oci-register-machine-76fc0b3e8cb7f838fe852b8a5b61920db2c05920:/builddir/build/BUILD/oci-register-machine-76fc0b3e8cb7f838fe852b8a5b61920db2c05920/Godeps/_workspace:/usr/share/gocode + make -j16 build docs GOPATH=$GOPATH:/usr/share/gocode go build -a -ldflags " -B 0x03268ff1213dbfc1372d7f5ec22c6812f08adead" -o oci-register-machine go-md2man -in "oci-register-machine.1.md" -out "oci-register-machine.1" sed -i 's|$HOOKSDIR|/usr/libexec/oci/hooks.d|' oci-register-machine.1 # github.com/godbus/dbus Godeps/_workspace/src/github.com/godbus/dbus/conn.go:48: undefined: Handler Godeps/_workspace/src/github.com/godbus/dbus/conn.go:54: undefined: SignalHandler make: *** [oci-register-machine] Error 2 RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.4xgrte (%build) Bad exit status from /var/tmp/rpm-tmp.4xgrte (%build) Child returncode was: 1 Building with unbundled libs in Fedora is OK - https://koji.fedoraproject.org/koji/buildinfo?buildID=912966 And I see it, during the import of the fixed godbus you missed the 3 new files - default_handler.go, server_interfaces.go and transport_unixcred_freebsd.go - I'll an upstream ticked for it. and with freshly updated upstream it builds again - https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=13660326 Lokesh we have a fix for this in Fedora, oci-register-machine-0-3.10.gitcbf1b8f.fc27 can you build for RHEL. ack, i'll check with frantisek. (In reply to Lokesh Mandvekar from comment #11) > ack, i'll check with frantisek. I don't think this was ever built. Would it be possible to get a build soon? Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2962 |