Bug 1462443
| Summary: | Review Request: libaec - Adaptive Entropy Coding library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christoph Junghans <junghans> | ||||
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | ignatenko, orion, package-review, zbyszek | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | Flags: | zbyszek:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://fedoraproject.org/wiki/ForbiddenItems#szip | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-08-31 15:19:08 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Christoph Junghans
2017-06-17 18:15:04 UTC
Hmm, why am I on this review request? (In reply to Igor Gnatenko from comment #2) > Hmm, why am I on this review request? Mainly because you are the hdf5 maintainer and I wanted to make you aware as SZIP is an hdf thing. The description mentions a static library, but there's no static library in -devel (nor should there be). Please fix the description. Looks good, but I need at the licensing more carefully, hence no final review yet. (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > The description mentions a static library, but there's no static library in > -devel (nor should there be). Please fix the description. Fixed! Spec URL: http://junghans.github.io/fedora-review/libaec/libaec.spec SRPM URL: http://junghans.github.io/fedora-review/libaec/libaec-1.0.0-2.fc25.src.rpm Review.txt: http://junghans.github.io/fedora-review/libaec/review.txt Build log: https://travis-ci.org/junghans/fedora-review/builds/245548276 Raw Build log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/245548277/log.txt > > Looks good, but I need at the licensing more carefully, hence no final > review yet. The interesting part about algorithm patent is here: <https://gitlab.dkrz.de/k202009/libaec/blob/master/doc/patent.txt#L44> "any use of the subject matter is at your own risk and NASA cannot warrant that its use will satisfy your particular needs or that your use will not infringe on another's intellectual property rights." (In reply to Christoph Junghans from comment #5) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > > The description mentions a static library, but there's no static library in > > -devel (nor should there be). Please fix the description. > Fixed! > > Spec URL: http://junghans.github.io/fedora-review/libaec/libaec.spec > SRPM URL: > http://junghans.github.io/fedora-review/libaec/libaec-1.0.0-2.fc25.src.rpm > Review.txt: http://junghans.github.io/fedora-review/libaec/review.txt > Build log: https://travis-ci.org/junghans/fedora-review/builds/245548276 > Raw Build log: > https://s3.amazonaws.com/archive.travis-ci.org/jobs/245548277/log.txt The build log also has an output of licensecheck.txt: https://travis-ci.org/junghans/fedora-review/builds/245548276#L2720 > > > > > Looks good, but I need at the licensing more carefully, hence no final > > review yet. > The interesting part about algorithm patent is here: > <https://gitlab.dkrz.de/k202009/libaec/blob/master/doc/patent.txt#L44> > "any use of the subject matter is at your own risk and NASA cannot warrant > that its use will satisfy your particular needs or that your use will not > infringe on another's intellectual property rights." + license is acceptable for Fedora (BSD) + license is specified correctly (there are some GPL and MIT/X11 files, but those are build scripts) + package name is OK + builds and install fine + R/P/BR look correct + scriptlets are sane + %check is present and passes So the only non-trivial thing is the patent situation. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Patented_Software says that a written license grant is necessary. https://gitlab.dkrz.de/k202009/libaec/blob/master/doc/patent.txt#L44 is such a license grant, so it seems OK to include this in Fedora. > NASA cannot warrant [...] that your use will not infringe on another's intellectual property rights. Right. But that's always true, for any software, and seems to be a standard disclaimer that doesn't mean anything except that NASA allows use of the algorithm, without making any promises on behalf of other parties. Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libaec libaec-1.0.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-56ec5fb7e4 libaec-1.0.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-56ec5fb7e4 I updated the wiki on szip slightly: https://fedoraproject.org/w/index.php?title=Forbidden_items&diff=495449&oldid=492921 Created attachment 1292418 [details] hdf5: enable szip support through libaec With this patch we can now enable szip support in hdf5: https://koji.fedoraproject.org/koji/taskinfo?taskID=20122306 Patch was send to hdf5-owner. libaec-1.0.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. (In reply to Christoph Junghans from comment #12) > Created attachment 1292418 [details] > hdf5: enable szip support through libaec > > With this patch we can now enable szip support in hdf5: > https://koji.fedoraproject.org/koji/taskinfo?taskID=20122306 > > Patch was send to hdf5-owner. https://src.fedoraproject.org/rpms/hdf5/pull-request/1 (In reply to Christoph Junghans from comment #14) > > Patch was send to hdf5-owner. > https://src.fedoraproject.org/rpms/hdf5/pull-request/1 And merged. libaec-1.0.1-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fb600d5f60 libaec-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fb600d5f60 libaec-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |