Bug 1462803

Summary: [RFE] Add support for VM "Restart Guest", for RHV provider
Product: Red Hat CloudForms Management Engine Reporter: ldomb
Component: ProvidersAssignee: Tomas Jelinek <tjelinek>
Status: CLOSED CURRENTRELEASE QA Contact: Angelina Vasileva <anikifor>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: cpelland, dajohnso, gblomqui, jfrey, jhardy, kmorey, mgoldboi, michal.skrivanek, obarenbo, simaishi
Target Milestone: MVPKeywords: FutureFeature, RFE, TestOnly, ZStream
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: rhev
Fixed In Version: 5.9.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1478418 (view as bug list) Environment:
Last Closed: 2018-03-06 14:55:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Feature
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: RHEVM Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1478418, 1515565    

Description ldomb 2017-06-19 14:53:52 UTC
Description of problem:
When running a vm_reset on RHV 4.1 CFME is not able to reset as the method is missing

Version-Release number of selected component (if applicable):
5.8.0.17.20170525183055_6317a22

How reproducible:


Steps to Reproduce:
1. Create a VM on RHV 4.1 or use an existing one
2. reset the VM
3.

Actual results:

[----] E, [2017-06-19T10:23:34.464442 #11809:951140] ERROR -- : MIQ(MiqQueue#m_callback) Message id: [99000032225277]: undefined method `vm_reset' for #<ManageIQ::Providers::Redhat::InfraManager:0x00000014d92308>
[----] E, [2017-06-19T10:23:34.464711 #11809:951140] ERROR -- : MIQ(MiqQueue#m_callback) backtrace: /opt/rh/cfme-gemset/gems/activemodel-5.0.3/lib/active_model/attribute_methods.rb:433:in `method_missing'
/var/www/miq/vmdb/app/models/vm_or_template.rb:331:in `run_command_via_parent'
/var/www/miq/vmdb/app/models/vm/operations/guest.rb:54:in `raw_reset'
/var/www/miq/vmdb/app/models/mixins/miq_policy_mixin.rb:115:in `check_policy_prevent_callback'
/var/www/miq/vmdb/app/models/miq_queue.rb:414:in `m_callback'
/var/www/miq/vmdb/app/models/miq_queue.rb:383:in `delivered'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:118:in `deliver_queue_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:135:in `deliver_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:153:in `block in do_work'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:147:in `loop'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:147:in `do_work'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:336:in `block in do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:333:in `loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:333:in `do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:155:in `run'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:130:in `start'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:21:in `start_worker'
/var/www/miq/vmdb/app/models/miq_worker.rb:339:in `block in start_runner'
/opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork'
/opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.3/lib/nakayoshi_fork.rb:24:in `fork'
/var/www/miq/vmdb/app/models/miq_worker.rb:337:in `start_runner'
/var/www/miq/vmdb/app/models/miq_worker.rb:348:in `start'
/var/www/miq/vmdb/app/models/miq_worker.rb:266:in `start_worker'
/var/www/miq/vmdb/app/models/miq_worker.rb:150:in `block in sync_workers'
/var/www/miq/vmdb/app/models/miq_worker.rb:150:in `times'
/var/www/miq/vmdb/app/models/miq_worker.rb:150:in `sync_workers'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:53:in `block in sync_workers'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `each'
/var/www/miq/vmdb/app/models/miq_server/worker_management/monitor.rb:50:in `sync_workers'
/var/www/miq/vmdb/app/models/miq_server.rb:160:in `start'
/var/www/miq/vmdb/app/models/miq_server.rb:251:in `start'
/var/www/miq/vmdb/lib/workers/evm_server.rb:65:in `start'
/var/www/miq/vmdb/lib/workers/evm_server.rb:91:in `start'
/var/www/miq/vmdb/lib/workers/bin/evm_server.rb:4:in `<main>'



Expected results:
 reset should work as expected

Additional info:

Comment 3 Ilanit Stein 2017-06-20 06:32:28 UTC
reset VM power option is not supported for RHV provider.

We have Bug 1438690, that refer to having this option available in UI, 
though it is not supported. 

It should be either implemented (RFE), or removed from RHV VM power options.

Comment 4 Oved Ourfali 2017-06-20 06:37:43 UTC
As far as I understand, VM reset means "non-graceful" shutdown, which is something we can add.
Restart is more problematic, and should probably be removed.

Comment 5 Martin Betak 2017-06-26 10:52:15 UTC
Implemented guest reboot in https://github.com/ManageIQ/manageiq-providers-ovirt/pull/52

Comment 7 Ilanit Stein 2017-08-22 07:09:51 UTC
The fix in this bug is for adding VM "Restart Guest", and not VM "Reset".
There fore changing the bug title into Restart Guest, and changed it into an RFE.

Opened this Bug for VM "Reset":
Bug 1483857 - [RFE] Add support for VM "Reset", for RHV provider.

Comment 8 Ilanit Stein 2017-12-18 10:22:49 UTC
Verified on CFME-5.9.0.12/RHV-4.1.8.

Test plan run: 
RHEVM3/testrun?id=4_1_cfme_guest_restart_cfme_5_9_0_12_rhv_4_1_8