Bug 1463055

Summary: Logging install fails if openshift_logging_es_pv_selector not set. Doc indicates there should be a default of None.
Product: OpenShift Container Platform Reporter: Mike Fiedler <mifiedle>
Component: InstallerAssignee: ewolinet
Status: CLOSED ERRATA QA Contact: Mike Fiedler <mifiedle>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.0CC: aos-bugs, ewolinet, jokerman, mmccomas, myllynen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: the default pv selector for the logging pvc generation was none and was being interpreted as a variable Consequence: The playbook would fail because it couldnt find a variable of the name 'none' Fix: Updated the default to be '' Result: Playbook is able to correctly run to completion when not providing a pv selector
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-10 05:28:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mike Fiedler 2017-06-20 02:18:23 UTC
Description of problem:

Running the openshift-logging.yaml playbook against an inventory with no value for openshift_logging_es_pv_selector fails with the following error:

============

MSG:

the field 'vars' has an invalid value, which appears to include a variable that is undefined. The error was: {{ openshift_logging_es_pv_selector }}: {{ openshift_hosted_logging_storage_labels | default(null) }}: 'null' is undefined
==============


The documentation (and the functionality in previous releases) indicates the default value should be None.  See:  https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_logging/README.md

Version-Release number of selected component (if applicable): 3.6.116 and openshift-ansible master HEAD dfd8232ec9284c0207edad62d8cb65adee07ccd3


How reproducible: Always


Steps to Reproduce:

1.  Create a logging inventory without openshift_logging_es_pv_selector
2.  Run the byo/openshift-cluster/openshift-logging.yaml playbook


Actual results:

Install fails with message above

Expected results:

openshift_logging_es_pv_selector has a default value of None

Additional info:

[oo_first_master:vars]
openshift_deployment_type=openshift-enterprise
openshift_release=v3.6.0

openshift_logging_install_logging=true
openshift_logging_use_ops=false
openshift_logging_master_url=https://ec2-34-209-212-239.us-west-2.compute.amazonaws.com:8443
openshift_logging_master_public_url=https://ec2-34-209-212-239.us-west-2.compute.amazonaws.com:8443
openshift_logging_kibana_hostname=kibana.example.com
openshift_logging_namespace=logging
openshift_logging_image_prefix=registry.ops.openshift.com/openshift3/
openshift_logging_image_version=v3.6.116
openshift_logging_es_pvc_dynamic=true
openshift_logging_es_pvc_size=50Gi
openshift_logging_fluentd_use_journal=true
openshift_logging_es_pv_selector=None

Comment 3 Mike Fiedler 2017-06-27 09:03:07 UTC
Not fixed in openshift-ansible.noarch      3.6.126-1.git.0.58d33f0.el7

Moving back to POST

Comment 4 Scott Dodson 2017-06-27 21:35:22 UTC
in openshift-ansible-3.6.123.1002-1.git.0.506cfa7.el7

Comment 5 Mike Fiedler 2017-07-06 13:55:01 UTC
Verified on 3.6.133

Comment 7 errata-xmlrpc 2017-08-10 05:28:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1716