Bug 1463277

Summary: NoVNC WS proxy port hardcoded
Product: [oVirt] ovirt-engine Reporter: Vladimir Rulev <vrulev>
Component: WebSocket ProxyAssignee: Nobody <nobody>
Status: CLOSED DUPLICATE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.1.2.2CC: bugs, gshereme, rbarry, tjelinek
Target Milestone: ovirt-4.4.0Flags: rule-engine: ovirt-4.4?
tjelinek: planning_ack?
tjelinek: devel_ack?
tjelinek: testing_ack?
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-13 13:48:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladimir Rulev 2017-06-20 13:26:55 UTC
Description of problem:
If I change websocket proxy port from default (6100) noVNC client stops connecting.

Version-Release number of selected component (if applicable):
ovirt-engine-backend-4.1.2.2-1.el7.centos.noarch

How reproducible:
Always

Steps to Reproduce:
1. Change websocket proxy port in /etc/ovirt-engine/ovirt-websocket-proxy.conf.d/10-setup.conf and restart ovirt-websocket-proxy.
2. Set WebSocketProxy by engine-config to new port. Restart ovirt-engine.
3. Select NoVNC in Console options for some VM.
4. Open cosole.

Actual results:
NoVNC client reports it can not connect to port 6100.

Expected results:
Client should use new port specified in URL.

Additional info:
It seems value 6100 is hardcoded in novnc-main.jsp function checkAndConnect():
var url = new URL('wss://' + getHost() + ':6100/' + path);
If I change port here NoVNC connects.

This page should use port from URL, for exsample:
var port = WebUtil.getQueryVar('port', window.location.port);
var url = new URL('wss://' + getHost() + ':' + port + '/' + path);

Comment 1 Tomas Jelinek 2017-06-21 06:49:24 UTC
wow, indeed, it is hardcoded. Even all the other code to handle it properly and pass it to the novnc-main.jsp is there, only the last bit to actually consume is not there.

Comment 2 Ryan Barry 2018-11-13 13:48:36 UTC

*** This bug has been marked as a duplicate of bug 1608291 ***