Bug 1463512

Summary:	USS: stale snap entries are seen when activation/deactivation performed during one of the glusterd's unavailability
Product:	[Community] GlusterFS	Reporter:	Mohammed Rafi KC <rkavunga>
Component:	snapshot	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.11	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.11.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1448150	Environment:
Last Closed:	2017-08-12 13:07:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1448150
Bug Blocks:	1165648

Description Mohammed Rafi KC 2017-06-21 07:33:20 UTC

+++ This bug was initially created as a clone of Bug #1448150 +++

Description of problem:

stale snap entries are seen in uss path when activation/deactivation performed during one of the glusterd's unavailability. Even if glusterd brought back to normal state, those stale entries are not synced.

Version-Release number of selected component (if applicable):


How reproducible:

always

Steps to Reproduce:
1.create a snapshot and activate it
2.enable uss
3.kill one glusterd
4. deactivate snapshot from other glusterd
5. bring back the dead glusterd.
6. check the snapshot entry in the uss path (this mount should be through the dead glusterd)

Actual results:

snapshot entry is listed

Expected results:

snapshot entry should not list, becaus it is deactivated

Additional info:

--- Additional comment from Worker Ant on 2017-05-04 11:57:34 EDT ---

REVIEW: https://review.gluster.org/17178 (snapview-server : Refresh the snapshot list during each reconnect) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Worker Ant on 2017-05-05 03:07:59 EDT ---

REVIEW: https://review.gluster.org/17178 (snapview-server : Refresh the snapshot list during each reconnect) posted (#2) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Worker Ant on 2017-05-08 01:49:52 EDT ---

COMMIT: https://review.gluster.org/17178 committed in master by Raghavendra Bhat (raghavendra) 
------
commit 21115ae8b80c1ae0afe8427423ca5ecde40f0027
Author: Mohammed Rafi KC <rkavunga>
Date:   Thu May 4 20:56:43 2017 +0530

    snapview-server : Refresh the snapshot list during each reconnect
    
    Currently we are refreshing the snapshot list either when there is
    a request from glusterd or the very first initialization. But if
    anything changed after when glusterd is down then there is no
    mechanism to refresh the snashot dentries.
    
    This patch will refresh snapshot list during each reconnect
    
    Change-Id: I3ed655572d777f60d57dd479d190f75553591267
    BUG: 1448150
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/17178
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Amar Tumballi <amarts>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 1 Worker Ant 2017-06-21 07:33:55 UTC

REVIEW: https://review.gluster.org/17585 (snapview-server : Refresh the snapshot list during each reconnect) posted (#1) for review on release-3.11 by mohammed rafi  kc (rkavunga)

Comment 2 Worker Ant 2017-07-03 12:52:49 UTC

COMMIT: https://review.gluster.org/17585 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 78242268318ad85b8016cb012ed3de605d6e4b8c
Author: Mohammed Rafi KC <rkavunga>
Date:   Thu May 4 20:56:43 2017 +0530

    snapview-server : Refresh the snapshot list during each reconnect
    
    Currently we are refreshing the snapshot list either when there is
    a request from glusterd or the very first initialization. But if
    anything changed after when glusterd is down then there is no
    mechanism to refresh the snashot dentries.
    
    This patch will refresh snapshot list during each reconnect
    
    backport of>
    
    >Change-Id: I3ed655572d777f60d57dd479d190f75553591267
    >BUG: 1448150
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: https://review.gluster.org/17178
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >Reviewed-by: Amar Tumballi <amarts>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >Reviewed-by: Atin Mukherjee <amukherj>
    >Reviewed-by: Raghavendra Bhat <raghavendra>
    
    Change-Id: I3ed655572d777f60d57dd479d190f75553591267
    BUG: 1463512
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/17585
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-08-12 13:07:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.2, please open a new bug report.

glusterfs-3.11.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-July/031908.html
[2] https://www.gluster.org/pipermail/gluster-users/