Bug 1463528

Summary: [Perf] 35% drop in small file creates on smbv3 on *2
Product: [Community] GlusterFS Reporter: Mohammed Rafi KC <rkavunga>
Component: libgfapiAssignee: Mohammed Rafi KC <rkavunga>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.11CC: amukherj, anoopcs, asoman, bugs, ksandha, rhinduja, rhs-smb
Target Milestone: ---Keywords: Regression, Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.11.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1458768 Environment:
Last Closed: 2017-08-12 13:07:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1458768    
Bug Blocks: 1450830    

Comment 1 Worker Ant 2017-06-21 08:11:32 UTC
REVIEW: https://review.gluster.org/17237 (gfapi: fix handling of dot and double dot in path) posted (#2) for review on release-3.11 by mohammed rafi  kc (rkavunga)

Comment 2 Worker Ant 2017-06-21 08:11:38 UTC
REVIEW: https://review.gluster.org/17238 (tests/gfapi:Adding testcase to check handling of "." and "..") posted (#2) for review on release-3.11 by mohammed rafi  kc (rkavunga)

Comment 3 Worker Ant 2017-06-21 08:11:45 UTC
REVIEW: https://review.gluster.org/17590 (gfapi: change root lookup from nameless to named lookup) posted (#1) for review on release-3.11 by mohammed rafi  kc (rkavunga)

Comment 4 Worker Ant 2017-07-05 14:12:31 UTC
COMMIT: https://review.gluster.org/17237 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 91fbc6ea1f1475d5b4cc2eef0c5a5b9b2bfd186f
Author: Mohammed Rafi KC <rkavunga>
Date:   Wed May 3 17:19:57 2017 +0530

    gfapi: fix handling of dot and double dot in path
    
    This patch is to handle "." and ".." in file path. Which means
    this special dentry names will be resolved before sending fops
    on the path.
    
    Backport of>
    >Change-Id: I5e92f6d1ad1412bf432eb2488e53fb7731edb013
    >BUG: 1447266
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: https://review.gluster.org/17177
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: Niels de Vos <ndevos>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >Reviewed-by: Jeff Darcy <jeff.us>
    
    Change-Id: I5e92f6d1ad1412bf432eb2488e53fb7731edb013
    BUG: 1463528
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/17237
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Shyamsundar Ranganathan <srangana>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 5 Worker Ant 2017-07-05 14:13:28 UTC
COMMIT: https://review.gluster.org/17238 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 7555f71297d96d319098963e88006f74feac069d
Author: Mohammed Rafi KC <rkavunga>
Date:   Tue May 9 16:11:52 2017 +0530

    tests/gfapi:Adding testcase to check handling of "." and ".."
    
    Adding a testcase to check the proper handling of "." and ".."
    in gfapi path.
    The patch which fix the issue is https://review.gluster.org/#/c/17177
    
    Backportof>
    >Change-Id: I5c9cceade30f7d8a3b451b5f34f1cf9815729c4a
    >BUG: 1447266
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: https://review.gluster.org/17216
    >Smoke: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >Reviewed-by: Niels de Vos <ndevos>
    >Reviewed-by: Jeff Darcy <jeff.us>
    >CentOS-regression: Gluster Build System <jenkins.org>
    
    Change-Id: I5c9cceade30f7d8a3b451b5f34f1cf9815729c4a
    BUG: 1463528
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/17238
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Shyamsundar Ranganathan <srangana>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 6 Worker Ant 2017-07-06 14:04:38 UTC
COMMIT: https://review.gluster.org/17590 committed in release-3.11 by Shyamsundar Ranganathan (srangana) 
------
commit 3315740ef0dd3606206355dfd46a57f045cbd6b4
Author: Mohammed Rafi KC <rkavunga>
Date:   Fri Jun 2 16:28:40 2017 +0530

    gfapi: change root lookup from nameless to named lookup
    
    Problem:
    
    During component resolve we do lookup on root based on
    root gfid. If we are doing nameless lookup, then md-cache
    won't be able to serve those lookup.
    
    Solution:
    
    With this patch, we covert nameless lookup to named lookup
    on root.
    
    Credits: Poornima G <pgurusid>
    
    backport of>
    >Change-Id: Ie64141936fd294d8969c39e3bd4dbc73ee375c6b
    >BUG: 1458768
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: https://review.gluster.org/17465
    >Smoke: Gluster Build System <jenkins.org>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >Reviewed-by: Niels de Vos <ndevos>
    
    Change-Id: Ie64141936fd294d8969c39e3bd4dbc73ee375c6b
    BUG: 1463528
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: https://review.gluster.org/17590
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Shyamsundar Ranganathan <srangana>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 7 Shyamsundar 2017-08-12 13:07:04 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.2, please open a new bug report.

glusterfs-3.11.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-July/031908.html
[2] https://www.gluster.org/pipermail/gluster-users/