Bug 146389
Summary: | NetworkManager-0.3.3-1.cvs20050119.2.fc3 doesn't set search in resolv.conf | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Thomas J. Baker <tjb> | ||||||||
Component: | NetworkManager | Assignee: | Colin Walters <walters> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | |||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | 3 | CC: | dcbw | ||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | i686 | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2005-04-12 14:49:43 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Thomas J. Baker
2005-01-27 19:54:45 UTC
-> Colin (WRT ipw2200, we mostly try to stay with upstream kernels for Fedora, so when the ipw drivers are upstream, they'll get into fedora...) Are there any log messages relating to it? Created attachment 110454 [details]
partial /var/log/messsages showing nm messages
nm is logging all the correct things but the actual /etc/resolv.conf file lacks
the search directive:
continuity> cat /etc/resolv.conf
; generated by NetworkManager, do not edit!
nameserver 132.177.241.111
nameserver 132.177.241.100
nameserver 132.177.241.27
continuity>
Hi, I'm an idiot. Dan, can you review and apply this patch? Created attachment 110474 [details]
really use searches
Note this patch includes a fix to use the correct syntax for multi-domain
searches.
Colin, I assume this is for resolv.conf, right? Isn't the format of resolv.conf "search domain1 domain2"? It looks like this patch would do "search domain1 search domain2". We should probably move the g_append_str ("search ") to compute_domain_searches() instead... Is that a correct read of the situation? Dan Created attachment 110538 [details]
Do searches v2
Colin, does this look better? Also in rewrite_resolv_conf() it looks like the
"searches" line would get appended to the file twice, once by the first
fprintf() right under compute_domain_searches() and then next inside the
#ifndef NM_NO_NAMED... If that's correct, then the patch fixes that too.
Dan, looks good to me. committed to CVS FWIW, I added the patch to the current SRPM of NM and all it does is add a blank line to the resolv.conf file :( The patch appeared to apply cleanly. Hmm, worksforme. Can you post the output of your DHCP transaction as reported by /var/log/messages? I'm fairly sure that the only way that you won't get a search domain is if the DHCP server doesn't give you one. FWIW, current CVS has an updated version of this patch that fixes a few things. Dan here is the relevant log: Feb 2 16:46:08 continuity NetworkManager: debug_dump_dhcp_options: 11 options received: Feb 2 16:46:08 continuity NetworkManager: i=1 (subnetMask) len=4 option = 255.255.255.0 Feb 2 16:46:08 continuity NetworkManager: i=3 (routersOnSubnet) len=4 option = 10.0.1.254 Feb 2 16:46:08 continuity NetworkManager: i=6 (dns) len=12 option = 10.0.1.1 Feb 2 16:46:08 continuity NetworkManager: i=6 (dns) len=12 option = 10.0.1.254 Feb 2 16:46:08 continuity NetworkManager: i=6 (dns) len=12 option = 132.177.241.100 Feb 2 16:46:08 continuity NetworkManager: i=12 (hostName) len=39 option = "continuity.bakerconsulting.com_wireless" Feb 2 16:46:08 continuity NetworkManager: i=15 (domainName) len=19 option = "bakerconsulting.com" Feb 2 16:46:08 continuity NetworkManager: i=28 (broadcastAddr) len=4 option = 10.0.1.255 Feb 2 16:46:08 continuity NetworkManager: i=51 (dhcpMessageType) len=4 option = 86400 Feb 2 16:46:08 continuity NetworkManager: i=53 (dhcpParamRequest) len=1 option = 5 Feb 2 16:46:08 continuity NetworkManager: i=54 (dhcpMsg) len=4 option = 127.0.0.1 Feb 2 16:46:08 continuity NetworkManager: i=58 (dhcpClassIdentifier) len=4 option = 0 Feb 2 16:46:08 continuity NetworkManager: i=59 (dhcpClientIdentifier) len=4 option = 0 Feb 2 16:46:08 continuity NetworkManager: dhcp_msg->yiaddr = 10.0.1.150 Feb 2 16:46:08 continuity NetworkManager: dhcp_msg->siaddr = 127.0.0.1 Feb 2 16:46:08 continuity NetworkManager: dhcp_msg->giaddr = 0.0.0.0 Feb 2 16:46:08 continuity NetworkManager: dhcp_msg->sname = "" Feb 2 16:46:08 continuity NetworkManager: Server Hardware Address = 00.40.05.A2.DD.68 Feb 2 16:46:08 continuity NetworkManager: DHCP_ACK received from (127.0.0.1) Feb 2 16:46:08 continuity NetworkManager: Your IP address = 10.0.1.150 Feb 2 16:46:08 continuity NetworkManager: : Adding nameserver: 10.0.1.1 Feb 2 16:46:08 continuity NetworkManager: : Adding nameserver: 10.0.1.254 Feb 2 16:46:08 continuity NetworkManager: : Adding nameserver: 132.177.241.100 Feb 2 16:46:08 continuity NetworkManager: : Adding domain search: bakerconsulting.com Feb 2 16:46:08 continuity NetworkManager: Restarting mDNSResponder. Feb 2 16:46:08 continuity NetworkManager: nm_state_modification_monitor() activated device eth1 How soon to an FC3 release of current CVS? Hopefully by tomorrow in FC3-updates-testing? Cool, thanks. I'll look for it then. So how about that FC3 update? The one from rawhide that just came out can't be installed on FC3 without half of rawhide with it. I've built one to tide my over but I'm using NM on quite a few laptops in our environment so it would be good to have an update from the normal feeds. Fixed. |