Bug 1464243
| Summary: | date dialogs with "Show Past Dates" unchecked still allow selection of past dates | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Saif Ali <saali> | ||||
| Component: | UI - OPS | Assignee: | Roman Blanco <rblanco> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Niyaz Akhtar Ansari <nansari> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.8.0 | CC: | abellott, dajohnso, dmetzger, hkataria, jhardy, jocarter, lavenel, mfeifer, mpovolny, nansari, obarenbo, rblanco, sacpatil, simaishi, yrudman, ytale | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.10.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.10.0.25 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1498542 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-05-22 14:50:21 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1498542 | ||||||
| Attachments: |
|
||||||
|
Description
Saif Ali
2017-06-22 19:01:13 UTC
The problem is actually more severe than expected here. In one page load, all Date Pickers in the same dialog can only be the same start date, because calDateFrom is stored as global variable (ManageIQ.calendar.calDateFrom). Also, this has a potential problem with zone. In my time zone (New York -5:00), after get start date work and previous dates not selectable, I can still select yesterday (can't select the day before yesterday). New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/8949d8d7a5e592af11a4c59c0b62d5272a342c68 commit 8949d8d7a5e592af11a4c59c0b62d5272a342c68 Author: Bo Yao <boyao> AuthorDate: Wed Jul 26 11:49:32 2017 -0400 Commit: Bo Yao <boyao> CommitDate: Wed Jul 26 11:49:32 2017 -0400 Add per datepicker property for start date https://bugzilla.redhat.com/show_bug.cgi?id=1464243 app/views/miq_ae_customization/_dialog_sample.html.haml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Created attachment 1382108 [details] Show past dates Still showing past dates even when the "Show past dates " switch says "No" Build : 5.9.0.16.20180109204148_7ac9852 Appliance : https://10.8.198.157 Service : Generic. New commit detected on ManageIQ/ui-components/master: https://github.com/ManageIQ/ui-components/commit/ba92a71ae51f0906e68fae11b9cd8e4444480ea3 commit ba92a71ae51f0906e68fae11b9cd8e4444480ea3 Author: Roman Blanco <rblanco> AuthorDate: Thu Oct 25 06:41:35 2018 -0400 Commit: Roman Blanco <rblanco> CommitDate: Thu Oct 25 06:41:35 2018 -0400 Past days selection in date control fields corrected Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1464243 src/dialog-user/components/dialog-user/dialogField.html | 2 + src/dialog-user/components/dialog-user/dialogField.ts | 16 + 2 files changed, 18 insertions(+) New commit detected on ManageIQ/ui-components/hammer: https://github.com/ManageIQ/ui-components/commit/36d6a1a7943e4ae6650eac022012c3738fe70019 commit 36d6a1a7943e4ae6650eac022012c3738fe70019 Author: Martin Povolny <mpovolny> AuthorDate: Mon Nov 12 06:38:04 2018 -0500 Commit: Martin Povolny <mpovolny> CommitDate: Mon Nov 12 06:38:04 2018 -0500 Merge pull request #355 from romanblanco/bz1464243 Past days selection in date control fields corrected (cherry picked from commit c17d2aa45943a69151a44c4c6773c6ac872c3a34) https://bugzilla.redhat.com/show_bug.cgi?id=1464243 src/dialog-user/components/dialog-user/dialogField.html | 2 + src/dialog-user/components/dialog-user/dialogField.ts | 16 + 2 files changed, 18 insertions(+) https://github.com/ManageIQ/ui-components/pull/355 is included in ui-components v1.1.18 ui-components v1.1.18 bump: https://github.com/ManageIQ/manageiq-ui-classic/pull/4914 https://github.com/ManageIQ/manageiq-ui-service/pull/1491 The fix is in 5.10.0.25 and later build. Verified in Version 5.10.4.0.20190424160602_acb6009 |