Bug 1464547

Summary:	OS_TENANT_NAME is replaced with OS_PROJECT_NAME in overcloudrc
Product:	Red Hat OpenStack	Reporter:	Chris Dearborn <christopher_dearborn>
Component:	rhosp-director	Assignee:	Brad P. Crochet <brad>
Status:	CLOSED WONTFIX	QA Contact:	Amit Ugol <augol>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	10.0 (Newton)	CC:	arkady_kanevsky, brad, cdevine, christopher_dearborn, dbecker, dcain, John_walsh, jslagle, kurt_hey, mburns, morazi, rajini.karthik, randy_perryman, rhel-osp-director-maint, smerrow, sreichar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Deprecated Functionality
Doc Text:	The overcloudrc from OSP 10 forward will use the OS_PROJECT_NAME environment variable instead of OS_TENANT_NAME, which was deprecated in the upstream Kilo release. From a user perspective, this should have no impact. Existing scripts that relied on the OS_TENANT_NAME variable may be affected.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-06-29 17:58:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1356451

Description Chris Dearborn 2017-06-23 17:59:37 UTC

Description of problem:
Our scripting depended on OS_TENANT_NAME being in the overcloudrc, which is the case with the version of OSP10 on CDN.  In the RC puddle, OS_TENANT_NAME has been replaced with OS_PROJECT_NAME in the overcloudrc.

Version-Release number of selected component (if applicable):
http://download-node-02.eng.bos.redhat.com/rcm-guest/puddles/OpenStack/10.0-RHEL-7/2017-06-19.1/

How reproducible:
Do an overcloud deployment, then look in the overcloudrc.

Steps to Reproduce:
See above.

Actual results:
OS_TENANT_NAME is missing from the overcloudrc

Expected results:
OS_TENANT_NAME should be present in the rc?

Additional info:

Comment 1 Chris Dearborn 2017-06-23 18:10:27 UTC

It seems like if OS_TENANT_NAME has been deprecated, then it's ok to remove it from the overcloudrc.  If it hasn't yet been deprecated, then it seems like it should be in that file.

Just my 2 cents.

Comment 2 Brad P. Crochet 2017-06-27 18:46:39 UTC

OS_TENANT_NAME was deprecated in the Kilo release. OS_PROJECT_NAME is the preferred variable.

I am unclear how OSP10 would generate OS_TENANT_NAME but a puddle would generate something different.

Comment 3 Brad P. Crochet 2017-06-27 18:49:55 UTC

I see where it was introduced...

The overcloudrc generation code was moved to tripleo-common, but wasn't actually utilized from the client.

The move to use that was backported here: https://review.openstack.org/#/c/410272/

OS_PROJECT_NAME is the proper variable to use.

Comment 4 Chris Dearborn 2017-06-27 19:14:06 UTC

I understand, but all customers that have OSP10 installed have OS_TENANT_NAME in their overcloudrc, and not OS_PROJECT_NAME.  If this ships as-is, then as soon as they do a yum update, their CLIs will be instantly be broken, generating support calls.

As I mentioned before, I already patched our scripting so we are not affected by the change.  Just trying to help out here.

Comment 5 Brad P. Crochet 2017-06-27 19:44:14 UTC

How are the CLIs broken by the change? They are effectively the same thing (or at least should be).

Do you have some specific problems that you saw?

Comment 6 Chris Dearborn 2017-06-27 21:35:05 UTC

Ah - sorry, I'm getting issues confused.  As far as I'm aware, the only issue is that code that depends on OS_TENANT_NAME being present will no longer work.  This is what happened to us.

Comment 7 Brad P. Crochet 2017-06-29 17:58:20 UTC

As long as it doesn't actually break anything, we consider this an implementation detail and not a breaking change. Thanks for the report. I will add some doctext on this bug so it can at least be captured in release notes.