Bug 1464735

Summary:	Do not execute sql scripts as shell scripts
Product:	[oVirt] ovirt-engine	Reporter:	Eli Mesika <emesika>
Component:	Database.Core	Assignee:	Eli Mesika <emesika>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lucie Leistnerova <lleistne>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	bugs, lsvaty, mperina
Target Milestone:	ovirt-4.2.0	Flags:	rule-engine: ovirt-4.2+ lsvaty: testing_ack+
Target Release:	4.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-12-20 11:24:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eli Mesika 2017-06-25 08:22:37 UTC

Description of problem:

If sql scripts are changed by mistake manually and have the execution flag set, the upgrade process will fail while trying to execute those sql scripts as shell scripts

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Change one/more of the sql scripts under upgrade/pre-upgrade/post-upgrade dir 
2. run engine-setup 
3.

Actual results:

Upgrade process fails while trying to execute the sql script as a shell script 

Expected results:

Upgrade process should ignore the execution flag and not try to run sql scripts as shell scripts


Additional info:

Comment 1 Lucie Leistnerova 2017-09-01 08:46:40 UTC

updgrade doesn't run .sql files

verified in ovirt-engine-4.2.0-0.0.master.20170831223128.git34f4d69.el7.centos.noarch

Comment 2 Sandro Bonazzola 2017-12-20 11:24:23 UTC

This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.