Bug 1464746

Summary: [New UI] - User is not authorized to perform action of create new 'QoS' entity
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: Frontend.WebAdminAssignee: Phillip Bailey <phbailey>
Status: CLOSED CURRENTRELEASE QA Contact: Artyom <alukiano>
Severity: high Docs Contact:
Priority: medium    
Version: 4.2.0CC: bugs, dfediuck, mavital, oourfali, phbailey
Target Milestone: ovirt-4.2.0Keywords: Regression
Target Release: ---Flags: rule-engine: ovirt-4.2+
rule-engine: blocker+
rule-engine: planning_ack+
msivak: devel_ack+
mavital: testing_ack+
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:10:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log none

Description Michael Burman 2017-06-25 11:46:56 UTC
Created attachment 1291696 [details]
engine log

Description of problem:
[New UI] [Host QoS] -  User is not authorized to perform action of create new 'Host QoS' 

Now it's not possible to create new Host QoS entity at all. Not via the DC flow and now via the network flow. 
Now we get that user not authorized to perform this action. 

2017-06-25 14:38:39,144+03 INFO  [org.ovirt.engine.core.bll.qos.AddHostNetworkQosCommand] (default task-8) [3eff369d-0c94-44c2-a650-6e955ac17f63] No permission found for user '586c19dc-00b9-00fa-0364-00000000012f' or one of the groups he is member of, when running action 'AddHostNetworkQos', Required permissions are: Action type: 'ADMIN' Action group: 'EDIT_STORAGE_POOL_CONFIGURATION' Object type: 'Data Center'  Object ID: 'null'.
2017-06-25 14:38:39,144+03 WARN  [org.ovirt.engine.core.bll.qos.AddHostNetworkQosCommand] (default task-8) [3eff369d-0c94-44c2-a650-6e955ac17f63] Validation of action 'AddHostNetworkQos' failed for user admin@internal-authz. Reasons: VAR__TYPE__QOS,VAR__ACTION__ADD,USER_NOT_AUTHORIZED_TO_PERFORM_ACTION


Version-Release number of selected component (if applicable):
4.2.0-0.0.master.20170624071949.gitff9611b.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Try to create new 'Host QoS' entity via DC or network flows. 

Actual results:
'Error while executing action: User is not authorized to perform this action.'

Expected results:
Should work as expected

Comment 1 Michael Burman 2017-06-25 11:55:14 UTC
Relevant to all 'QoS' entities - CPU, Host QoS, VM QoS and Storage. 
User not authorized to create any of those entities. 

Validation of action 'AddStorageQos' failed for user admin@internal
Validation of action 'AddCpuQos' failed for user admin@internal
Validation of action 'AddNetworkQoS' failed for user admin@internal
Validation of action 'AddHostNetworkQos' failed for user admin@internal

Comment 2 Oved Ourfali 2017-06-26 05:42:55 UTC
Moving to SLA.
Not sure that's related to the new ui, as it complains on permissions.

Martin, can one of you take a look?

Comment 3 Red Hat Bugzilla Rules Engine 2017-07-12 10:33:35 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 4 Michael Burman 2017-07-19 12:39:51 UTC
Still relevant for current master 4.2.0-0.0.master.20170717104433.gita1ba045.el7.centos

Comment 5 Michael Burman 2017-09-04 05:28:01 UTC
Hi Philip,

The New/edit Network > New Host Network QoS wasn't fixed.
We still get the same error - "Error while executing action: User is not authorized to perform this action."
Only the DC > New QoS fixed. But when trying to create host QoS via the network, we still blocked with same error. 4.2.0-0.0.master.20170903205106.gitb17261a.el7.centos 
Should this be fixed here?(i have wrote this in steps to reproduce - 1. Try to create new 'Host QoS' entity via DC or network flows) or you want a separate bug?

Comment 6 Phillip Bailey 2017-09-04 20:50:06 UTC
Hi Michael,

I'm sorry. I don't know how I missed that. I'm looking into the issue. It looks like it's the same root cause, but I haven't yet tracked down where I need to place the fix, yet. No need for a new ticket, though. I'll move this back to post.

Comment 7 Michael Burman 2017-09-05 04:48:17 UTC
(In reply to Phillip Bailey from comment #6)
> Hi Michael,
> 
> I'm sorry. I don't know how I missed that. I'm looking into the issue. It
> looks like it's the same root cause, but I haven't yet tracked down where I
> need to place the fix, yet. No need for a new ticket, though. I'll move this
> back to post.

Thank you Phillip)

Comment 8 Yaniv Kaul 2017-10-15 10:12:44 UTC
Can we move this to MODIFIED, or are there additional patches needed (not clear from comment 6 ) ?

Comment 9 Phillip Bailey 2017-10-16 19:46:17 UTC
Sorry, Yaniv. This was fixed with the second patch [1]. Moving to MODIFIED now.

[1] https://gerrit.ovirt.org/#/c/81425/

Comment 10 Michael Burman 2017-10-23 05:52:13 UTC
Hi Artyom, i can confirm that the New/edit Network > New Host Network QoS scenario is now fixed(4.2.0-0.0.master.20171022103432.gitaf9d8b6.el7.centos)

Comment 11 Artyom 2017-10-24 11:26:34 UTC
Thanks Michael

Comment 12 Sandro Bonazzola 2017-12-20 11:10:41 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.