Bug 1465304

Summary: [trello EVOHdIMU] avoid to add path (sub-folder) in front of the vserver name if have specified custom partition and path
Product: OpenShift Container Platform Reporter: Hongan Li <hongli>
Component: NetworkingAssignee: Rajat Chopra <rchopra>
Networking sub component: router QA Contact: zhaozhanqi <zzhao>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: aos-bugs, bbennett, eparis, xtian
Version: 3.6.0   
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: The code path prepends the partition name automatically to vserver name. Consequence: If the vserver is in a path of length more than 1, then the path is lost because only the partition name is prepended. This leads to 'vserver' not found errors. Fix: Prepend the entire path of vserver instead of just concatenating partition name and vserver name. Result: vserver can now be found even if it is located in a path of length more than one.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-28 21:58:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hongan Li 2017-06-27 07:26:30 UTC 
Description of problem:
User can specified custom partition and path when creating F5 router pod, that means the vserver has been created in the partition and path, but it will failed to create F5 router and pod logs shows error: "The requested Virtual Server (/Ocp/ocp-http-vserver) was not found." Actually, the vserver should be in /Ocp/path/ocp-http-vserver, the "path" is missing when request the vserver.

Workaround is add path in front of the vserver name, for example:
oadm router f5router --type=f5-router \ 
--external-host-http-vserver=path/ocp-http-vserver \
--external-host-https-vserver=path/ocp-https-vserve \
--external-host-partition-path=Ocp/path \
<---snip--->

but it might confusing user since they have specified the path in option --external-host-partition-path.
 

Version-Release number of selected component (if applicable):
openshift v3.6.125
kubernetes v1.6.1+5115d708d7
etcd 3.2.0

How reproducible:
always

Steps to Reproduce:
1. oadm router f5router --replicas=1 --type=f5-router --external-host=10.x.x.x --external-host-username=user --external-host-password=password --external-host-http-vserver=path/ocp-http-vserver --external-host-https-vserver=path/ocp-https-vserver --external-host-private-key=/root/.ssh/id_rsa  --service-account=router --external-host-insecure=true --external-host-internal-ip=10.x.x.x --external-host-vxlan-gw=10.130.0.1/14 --external-host-partition-path=Ocp/path
2.
3.

Actual results:
should add path in front of the vserver name, otherwise will failed to start F5 router pod.

Expected results:
needn't to add extra path in front of the vserver name, just like: 
--external-host-http-vserver=ocp-http-vserver
--external-host-https-vserver=ocp-https-vserver
--external-host-partition-path=Ocp/path

Additional info:
Comment 1 Rajat Chopra 2017-06-28 15:11:57 UTC 
Fixed with https://github.com/openshift/origin/pull/14940
Comment 3 Hongan Li 2017-07-05 08:57:47 UTC 
verified in atomic-openshift-3.6.133-1.git.0.524e4c8.el7.x86_64 and the issue has been fixed.
Comment 7 errata-xmlrpc 2017-11-28 21:58:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188