Bug 1465327
| Summary: | command line tool json-diff is not packaged in nodejs-json-diff | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Bukatovic <mbukatov> |
| Component: | nodejs-json-diff | Assignee: | Piotr Popieluch <piotr1212> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 25 | CC: | jsmith.fedora, piotr1212 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-12-12 10:31:44 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Martin Bukatovic
2017-06-27 08:40:34 UTC
I tried to create json-diff file myself based on upstream code:
$ cat ~/bin/json-diff
#!/usr/bin/env node
require('/usr/lib/node_modules/json-diff/lib/cli.js')(process.argv.slice(2));
But this first idea I had doesn't work:
$ json-diff --help
/usr/lib/node_modules/dreamopt/lib/dreamopt.js:491
throw new Error("Array must follow a command spec: " + (JSON.stringify(spec)));
^
Error: Array must follow a command spec: " first.json Old file #var(file1) #required"
at Syntax.add (/usr/lib/node_modules/dreamopt/lib/dreamopt.js:491:19)
at parse (/usr/lib/node_modules/dreamopt/lib/dreamopt.js:866:12)
at module.exports (/usr/lib/node_modules/json-diff/lib/cli.js:56:34)
at Object.<anonymous> (/home/martin/bin/json-diff:2:54)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
And I'm not a javascript expert, so I'm not exactly sure who's to blame here.
It works after I recompile the source with iced-coffee-script. iced-coffee-script is not in Fedora yet so it will need to be packaged first. Also note that the error handling in json-diff is far from perfect, it throws an exception when I don't supply any arguments. Adding Jared, what should we do about this? This message is a reminder that Fedora 25 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '25'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 25 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. Sorry for the delay -- I've gone ahead and fixed this in RAWHIDE as part of a version upgrade on json-diff. If you'd like me to push it to F26 or F27, please let me know. |