Bug 1465599

Summary:	Fix multiple issues with xt action
Product:	Red Hat Enterprise Linux 7	Reporter:	Jaroslav Aster <jaster>
Component:	iproute	Assignee:	Phil Sutter <psutter>
Status:	CLOSED ERRATA	QA Contact:	Jaroslav Aster <jaster>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.4	CC:	atragler, psutter, rkhan, sukulkar, vbenes
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	iproute-4.11.0-5.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1326726	Environment:
Last Closed:	2018-04-10 14:28:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1470965

Description Jaroslav Aster 2017-06-27 17:42:47 UTC

Bug for remaining issues from bug bz#1326726. Still not fully fixed. Tested on

iproute-3.10.0-87.el7

+++ This bug was initially created as a clone of Bug #1326726 +++

--- Additional comment from Phil Sutter on 2017-05-18 14:19:34 EDT ---

Hi Jaroslav,

(In reply to Jaroslav Aster from comment #6)
> Hi Phil,
> 
> unfortunately I see still a lot of fails and segfaults in my test case. Yes,
> there is some progress, but it is not definitely fixed. See
> 
> http://beaker-archive.app.eng.bos.redhat.com/beaker-logs/2017/04/18159/
> 1815921/3752192/54687568/TESTOUT.log

Yes, xt action is still buggy. The segfaults are all related to using any of the NAT targets (SNAT, DNAT, MASQUERADE and REDIRECT). I found the reason why it segfaults (which happens in libipt, BTW) and I have a workaround at hand. Problem is, these targets will still refuse to work then, just the segfault does not happen anymore.

Other non-functional targets are internal ones (ACCEPT, DROP, RETURN). This is also a known issue upstream.

You see, xt action has very limited use even upstream and so I don't see much sense in trying to get all these things functional.

Comment 1 Phil Sutter 2017-07-26 09:23:54 UTC

Upstream commit to backport (which prevents the segfault at least):

commit f6fc1055e41a8a924313c336b39b9ffe0c86938b
Author: Phil Sutter <psutter>
Date:   Tue May 23 15:40:57 2017 +0200

    tc: m_xt: Prevent a segfault in libipt
    
    This happens with NAT targets, such as SNAT, DNAT and MASQUERADE. These
    are still not usable with this patch, but at least tc doesn't crash
    anymore when one tries to use them.
    
    Signed-off-by: Phil Sutter <phil>

Comment 3 Jaroslav Aster 2017-11-08 13:32:36 UTC

Hi Phil,

I can confirm that there are no segfaults anymore, but there are still a lot of issues to solve.

I'm not sure what we should do with this bug.

Comment 4 Phil Sutter 2017-11-08 15:15:45 UTC

Hi Jaroslav,

(In reply to Jaroslav Aster from comment #3)
> Hi Phil,
> 
> I can confirm that there are no segfaults anymore, but there are still a lot
> of issues to solve.
> 
> I'm not sure what we should do with this bug.

There are conceptual problems with xt action, I don't think it is even possible to address all of them. Assuming that anyone using it should be aware of its limitations, I'd say making sure tc doesn't crash is about the best we can do.

Comment 6 Phil Sutter 2017-12-13 17:19:19 UTC

*** Bug 1513973 has been marked as a duplicate of this bug. ***

Comment 9 errata-xmlrpc 2018-04-10 14:28:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0815