Bug 1465683

Summary: rule_accounts_have_homedir_login_defs has reversed check
Product: Red Hat Enterprise Linux 7 Reporter: Marek Haicman <mhaicman>
Component: scap-security-guideAssignee: Watson Yuuma Sato <wsato>
Status: CLOSED ERRATA QA Contact: Marek Haicman <mhaicman>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.4CC: amitkuma, cparadka, jcerny, matyc, mhaicman, mmarhefk, mpreisle, openscap-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: scap-security-guide-0.1.35-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 12:20:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marek Haicman 2017-06-27 23:25:55 UTC
Description of problem:
This rule is supposed to check every user is create with home directory. OVAL check is reversed, thus checking for "no home directory created".

Rule is also missing remediation (fortunately, in this case)

Version-Release number of selected component (if applicable):
scap-security-guide-0.1.33-5.el7.noarch

How reproducible:
reliably

Steps to Reproduce:
1. perform scan of rule_accounts_have_homedir_login_defs
2.
3.

Actual results:
login.defs contains CREATE_HOME yes and rule is failing
no remediation is performed when failing

Expected results:
login.defs contains CREATE_HOME yes and rule is passing
remediation fixes the issue

Additional info:

Comment 1 Marek Haicman 2017-08-21 19:58:24 UTC
Fixed in upstream, PR: https://github.com/OpenSCAP/scap-security-guide/pull/1984

Comment 3 Marek Haicman 2018-01-22 13:50:21 UTC
Verified that version scap-security-guide-0.1.36-7.el7.noarch contains fix for OVAL check rule_accounts_have_homedir_login_defs. Test performed via SSG Test Suite:

OLD (scap-security-guide-0.1.33-6.el7.noarch):
[dahaic@machine]$ sudo ./test_suite.py rule --hypervisor 'qemu:///system' --domain ssg-test-suite --datastream ./ssg-0.1.33-6-ds.xml --benchmark xccdf_org.ssgproject.content_benchmark_RHEL-7 rule_accounts_have_homedir_login_defs
Setting console output to log level INFO
INFO - Logging into /home/dahaic/RH/git/upstream/dahaic/scap-security-guide/tests/logs/rule-custom-2018-01-22-1443/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_accounts_have_homedir_login_defs
ERROR - Script wrong_value.fail.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa found issue:
ERROR - Scan has exited with return code 0, instead of expected 2 during stage initial
ERROR - The initial scan failed for rule 'xccdf_org.ssgproject.content_rule_accounts_have_homedir_login_defs'.
INFO - Script comment.fail.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa OK
INFO - Script line_not_there.fail.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa OK
ERROR - Script correct_value.pass.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa found issue:
ERROR - Scan has exited with return code 2, instead of expected 0 during stage initial
ERROR - The initial scan failed for rule 'xccdf_org.ssgproject.content_rule_accounts_have_homedir_login_defs'.
INFO - All snapshots reverted successfully


NEW (scap-security-guide-0.1.36-7.el7.noarch):
[dahaic@machine]$ sudo ./test_suite.py rule --hypervisor 'qemu:///system' --domain ssg-test-suite --datastream ./ssg-0.1.36-7-ds.xml --benchmark xccdf_org.ssgproject.content_benchmark_RHEL-7 rule_accounts_have_homedir_login_defs
Setting console output to log level INFO
INFO - Logging into /home/dahaic/RH/git/upstream/dahaic/scap-security-guide/tests/logs/rule-custom-2018-01-22-1442/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_accounts_have_homedir_login_defs
INFO - Script wrong_value.fail.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa OK
INFO - Script comment.fail.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa OK
INFO - Script line_not_there.fail.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa OK
INFO - Script correct_value.pass.sh using profile xccdf_org.ssgproject.content_profile_stig-rhel7-disa OK
INFO - All snapshots reverted successfully


PR with test coverage: https://github.com/OpenSCAP/scap-security-guide/pull/2558

Comment 4 Marek Haicman 2018-01-22 22:26:16 UTC
*** Bug 1511661 has been marked as a duplicate of this bug. ***

Comment 5 Jan Černý 2018-01-23 07:24:21 UTC
The test case was merged upstream today in https://github.com/OpenSCAP/scap-security-guide/pull/2558

Comment 6 Watson Yuuma Sato 2018-02-07 10:57:13 UTC
*** Bug 1540541 has been marked as a duplicate of this bug. ***

Comment 9 errata-xmlrpc 2018-04-10 12:20:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0761