Bug 1466015

Summary:	[RFE] Add warning that we will remove backend CLI configuration options in a future release
Product:	Red Hat Enterprise Linux 7	Reporter:	Chris Snyder <csnyder>
Component:	virt-who	Assignee:	William Poteat <wpoteat>
Status:	CLOSED ERRATA	QA Contact:	Eko <hsun>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.5	CC:	rjerrido, sgao, wpoteat, yuefliu
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1469793 1469796 (view as bug list)		Environment:
Last Closed:	2018-04-10 16:21:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1469793, 1469796

Description Chris Snyder 2017-06-28 17:34:36 UTC

Description of problem:
Virt-who presently allows for specifying both the source (the management framework or other API) from which to gather information as well as the destination (where to report information from this source) on the CLI.

The options used to configure virt-who to do this on the CLI increase the complexity of virt-who configuration parsing.

I believe to ease the use of virt-who, only those options which affect the overall operation of virt-who should be allowed (see the following):

* "-c": Add a configuration to be read.
* "-p": Gather information from sources, print the information that would be sent but do not send it.
* "-d": enable debug output
* "-o": Run once, then exit (oneshot mode)
* "-i": Set the interval on which information is gathered from sources and delivered from destinations

All other options should be removed from the CLI.

In order to ease the transition, the first patch for this RFE should output messages indicating that the options to be removed are deprecated.

The next release of virt-who after the deprecation warnings are out should remove the options entirely.

Comment 2 Eko 2017-06-29 07:37:57 UTC

Hi Chris, I absolutely agree with you，
Further more, could we also remove the backend from /etc/sysconfig/virt-who and only keep the global options, that means the backend only can be configured by /etc/virt-who.d/xxx.conf, 

when running virt-who by CLI or by systemctl service, if no config files in /etc/virt-who.d, virt-who will run as local libvirt mode, otherwise, it will run all the backend according to /etc/virt-who.d/.

Comment 3 Chris Snyder 2017-07-11 20:51:00 UTC

To be clear for the dev that implements this: This RFE is not to actually remove the CLI options but to provide warning messages that the CLI options will be removed and to provide a temporary (debug) method of converting existing configuration involving CLI options to the format expected in files in /etc/virt-who.d/*.conf.

Comment 5 Chris Snyder 2017-09-25 18:54:14 UTC

This has been merged upstream and should be included in the first build for RHEL 7.5. As such moving this bug to MODIFIED.

Comment 9 yuefliu 2017-11-05 04:03:03 UTC

Verified the bug with virt-who-0.21.0-1.el7.noarch, when run virt-who by CLI it will give warning that - "The option --hypervisor_mode is deprecated and will be removed in the next release. Please see 'man virt-who-config' for details on adding a configuration section."


And NEW open Bug 1509606 about Comment 8

Comment 12 errata-xmlrpc 2018-04-10 16:21:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0895